You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (Jira)" <ji...@apache.org> on 2019/09/22 09:34:00 UTC
[jira] [Commented] (THRIFT-4951) clean up unsupported senum base
type from 0.9.1
[ https://issues.apache.org/jira/browse/THRIFT-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935270#comment-16935270 ]
Jens Geyer commented on THRIFT-4951:
------------------------------------
First, its called **deprecate** in that ticket, not **do not support anymore**. As long as stuff is only deprecated, it is still supported, hence it should be tested.
If we are going to remove support for it _entirely_ and not only from the IDL files (which I'm fine with) we should make sure we checked against [fbthrift|https://github.com/facebook/fbthrift] for compatibility reasons first. As long as they support it, we should as well. Not that we were in any way dependent on them, but we should IMHO strive to keep a certain compatibility level. We could of course consider to file a ticket at fbthrift to ask them to do the same ...
Bottom line: We should do our homework first here.
[~pengzhouhu]: Would you mind to follow up?
> clean up unsupported senum base type from 0.9.1
> -----------------------------------------------
>
> Key: THRIFT-4951
> URL: https://issues.apache.org/jira/browse/THRIFT-4951
> Project: Thrift
> Issue Type: Bug
> Components: Test Suite
> Affects Versions: 0.13.0
> Environment: thrift-master
> Reporter: pengzhouhu
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> clean up unsupported senum base types from 0.9.1
> refer to : [THRIFT-2003](https://issues.apache.org/jira/browse/THRIFT-2003) - Deprecate senum
--
This message was sent by Atlassian Jira
(v8.3.4#803005)