You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alex Rudyy (JIRA)" <ji...@apache.org> on 2017/10/25 16:04:05 UTC
[jira] [Updated] (QPID-7646) [Java Broker] fix
AbstractAMQPSession#getLocalTransactionOpen to support values > 1
[ https://issues.apache.org/jira/browse/QPID-7646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy updated QPID-7646:
-----------------------------
Attachment: QPID-7646-transaction-stats-refactoring.tar.gz
> [Java Broker] fix AbstractAMQPSession#getLocalTransactionOpen to support values > 1
> -----------------------------------------------------------------------------------
>
> Key: QPID-7646
> URL: https://issues.apache.org/jira/browse/QPID-7646
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Lorenz Quack
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: QPID-7646-transaction-stats-refactoring.tar.gz
>
>
> During the review of QPID-7633 it was noted:
> bq. Why do we only return 0 or 1 from AbstractAMQPSession#getLocalTransactionOpen. That seems wrong.
> which was followed up by Rob:
> bq. On getLocalTransactionOpen, I agree that looks very dodgy. In AMQP 0-x the value will only be 0 or 1, but I'm not sure the implementation the we have now is safe. I think the implementations will need to define this properly (i.e. the calculation will need to be atomic, and the value may be > 1 for AMQP 1.0 )
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org