[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #15808: Add option to choose between OMP implementations

[GitBox <gi...@apache.org>]

marcoabreu commented on a change in pull request #15808: Add option to choose between OMP implementations
URL: https://github.com/apache/incubator-mxnet/pull/15808#discussion_r321929537
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -432,14 +432,13 @@ endif()
 
 # ---[ OpenMP
 if(USE_OPENMP)
-  find_package(OpenMP REQUIRED)
   # This should build on Windows, but there's some problem and I don't have a Windows box, so
   # could a Windows user please fix?
-  if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/openmp/CMakeLists.txt
-     AND SYSTEM_ARCHITECTURE STREQUAL "x86_64"
-     AND NOT MSVC
-     AND NOT CMAKE_CROSSCOMPILING)
-
+  if(USE_OPENMP STREQUAL "BUNDLED" AND EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/openmp/CMakeLists.txt
 
 Review comment:
   The first check and the others should be separate to throw appropriate error messages

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services