You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2021/08/09 23:41:22 UTC
[kudu-CR] [consensus] remove ForTests suffix from WaitUntilLeader
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17763
Change subject: [consensus] remove ForTests suffix from WaitUntilLeader
......................................................................
[consensus] remove ForTests suffix from WaitUntilLeader
I found WaitUntilLeaderForTests useful in making the master rebuilder
tool more robust to slow startup. Since I intend on using it outside of
tests, I removed the ForTests suffix.
I also left a note in the header mentioning it should be used sparingly,
given the implementation is admittedly simple and not suited for heavy
usage.
This patch contains no functional changes.
Change-Id: I4f5d61a59651c3a5f11e317a77c0344f5dd3e707
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
11 files changed, 37 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/17763/1
--
To view, visit http://gerrit.cloudera.org:8080/17763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f5d61a59651c3a5f11e317a77c0344f5dd3e707
Gerrit-Change-Number: 17763
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] [consensus] remove ForTests suffix from WaitUntilLeader
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17763 )
Change subject: [consensus] remove ForTests suffix from WaitUntilLeader
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17763/1/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:
http://gerrit.cloudera.org:8080/#/c/17763/1/src/kudu/consensus/raft_consensus.h@188
PS1, Line 188: Status WaitUntilLeader(const MonoDelta& timeout)
> nit: does it make sense to add WARN_UNUSED_RESULT attribute?
Done
http://gerrit.cloudera.org:8080/#/c/17763/1/src/kudu/consensus/raft_consensus_quorum-test.cc
File src/kudu/consensus/raft_consensus_quorum-test.cc:
http://gerrit.cloudera.org:8080/#/c/17763/1/src/kudu/consensus/raft_consensus_quorum-test.cc@905
PS1, Line 905: // Make sure the last operation is
> Is it possible to replace this with
Done
--
To view, visit http://gerrit.cloudera.org:8080/17763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5d61a59651c3a5f11e317a77c0344f5dd3e707
Gerrit-Change-Number: 17763
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 10 Aug 2021 16:44:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] [consensus] remove ForTests suffix from WaitUntilLeader
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17763 )
Change subject: [consensus] remove ForTests suffix from WaitUntilLeader
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17763/1/src/kudu/consensus/raft_consensus.h
File src/kudu/consensus/raft_consensus.h:
http://gerrit.cloudera.org:8080/#/c/17763/1/src/kudu/consensus/raft_consensus.h@188
PS1, Line 188: Status WaitUntilLeader(const MonoDelta& timeout)
nit: does it make sense to add WARN_UNUSED_RESULT attribute?
http://gerrit.cloudera.org:8080/#/c/17763/1/src/kudu/consensus/raft_consensus_quorum-test.cc
File src/kudu/consensus/raft_consensus_quorum-test.cc:
http://gerrit.cloudera.org:8080/#/c/17763/1/src/kudu/consensus/raft_consensus_quorum-test.cc@905
PS1, Line 905: WaitUntilLeader(new_leader.get());
Is it possible to replace this with
ASSERT_OK(new_leader->WaitUntilLeader(MonoDelta::FromSeconds(15));
and remove the WaitUntilLeaderForTest() local function?
--
To view, visit http://gerrit.cloudera.org:8080/17763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5d61a59651c3a5f11e317a77c0344f5dd3e707
Gerrit-Change-Number: 17763
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 10 Aug 2021 01:07:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] [consensus] remove ForTests suffix from WaitUntilLeader
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17763
to look at the new patch set (#2).
Change subject: [consensus] remove ForTests suffix from WaitUntilLeader
......................................................................
[consensus] remove ForTests suffix from WaitUntilLeader
I found WaitUntilLeaderForTests useful in making the master rebuilder
tool more robust to slow startup. Since I intend on using it outside of
tests, I removed the ForTests suffix.
I also left a note in the header mentioning it should be used sparingly,
given the implementation is admittedly simple and not suited for heavy
usage.
This patch contains no functional changes.
Change-Id: I4f5d61a59651c3a5f11e317a77c0344f5dd3e707
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
11 files changed, 36 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/17763/2
--
To view, visit http://gerrit.cloudera.org:8080/17763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f5d61a59651c3a5f11e317a77c0344f5dd3e707
Gerrit-Change-Number: 17763
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [consensus] remove ForTests suffix from WaitUntilLeader
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17763 )
Change subject: [consensus] remove ForTests suffix from WaitUntilLeader
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5d61a59651c3a5f11e317a77c0344f5dd3e707
Gerrit-Change-Number: 17763
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 10 Aug 2021 02:39:00 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] remove ForTests suffix from WaitUntilLeader
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17763 )
Change subject: [consensus] remove ForTests suffix from WaitUntilLeader
......................................................................
[consensus] remove ForTests suffix from WaitUntilLeader
I found WaitUntilLeaderForTests useful in making the master rebuilder
tool more robust to slow startup. Since I intend on using it outside of
tests, I removed the ForTests suffix.
I also left a note in the header mentioning it should be used sparingly,
given the implementation is admittedly simple and not suited for heavy
usage.
This patch contains no functional changes.
Change-Id: I4f5d61a59651c3a5f11e317a77c0344f5dd3e707
Reviewed-on: http://gerrit.cloudera.org:8080/17763
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/txn_participant-itest.cc
M src/kudu/tablet/tablet_replica-test-base.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_server-test-base.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
11 files changed, 36 insertions(+), 45 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f5d61a59651c3a5f11e317a77c0344f5dd3e707
Gerrit-Change-Number: 17763
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)