You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/14 07:52:21 UTC
[GitHub] [pulsar-client-go] cornelk commented on a change in pull request
#214: Fix Consumer Seek not returning a potential error
cornelk commented on a change in pull request #214: Fix Consumer Seek not returning a potential error
URL: https://github.com/apache/pulsar-client-go/pull/214#discussion_r407935419
##########
File path: pulsar/consumer_impl.go
##########
@@ -283,8 +284,9 @@ func (c *consumer) Nack(msg Message) {
}
func (c *consumer) NackID(msgID MessageID) {
- mid, ok := c.messageID(msgID)
- if !ok {
+ mid, err := newMessageIDFromInterface(msgID, len(c.consumers))
Review comment:
if the `msgID` interface paramter is not of the internal type `messageID` `newMessageIDFromInterface()` will fail
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services