You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2012/05/09 17:37:50 UTC

[jira] [Created] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Daryn Sharp created HADOOP-8373:
-----------------------------------

             Summary: Port RPC.getServerAddress to 0.23
                 Key: HADOOP-8373
                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
             Project: Hadoop Common
          Issue Type: Improvement
          Components: ipc
    Affects Versions: 0.23.3
            Reporter: Daryn Sharp
            Assignee: Daryn Sharp


{{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271520#comment-13271520 ] 

Aaron T. Myers commented on HADOOP-8373:
----------------------------------------

Small clarification: I believe this function was introduced via PB changes, not HA. That probably doesn't change your reasoning for wanting it in branch-0.23, but I figured I'd point it out.

One question: why is it that this function is needed, if nothing is currently calling it in branch-0.23?
                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8373:
--------------------------------

    Status: Patch Available  (was: Open)
    
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8373.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271624#comment-13271624 ] 

Hudson commented on HADOOP-8373:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #2212 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2212/])
    HADOOP-8373. Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java

                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272351#comment-13272351 ] 

Hudson commented on HADOOP-8373:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1075 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1075/])
    HADOOP-8373. Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java

                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8373:
--------------------------------

    Attachment: TestRPC.trunk.patch

Trunk/2.0 is lacking a test for {{RPC.getServerAddress}}, so adding a patch for my new test.
                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271622#comment-13271622 ] 

Hudson commented on HADOOP-8373:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2287 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2287/])
    HADOOP-8373. Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java

                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8373:
--------------------------------

    Attachment: HADOOP-8373.patch

Minimal port of the method and required interface.
                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8373.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271606#comment-13271606 ] 

Aaron T. Myers commented on HADOOP-8373:
----------------------------------------

Got it, makes sense. Thanks for the info. No objections from me.
                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271601#comment-13271601 ] 

Daryn Sharp commented on HADOOP-8373:
-------------------------------------

Thanks for the clarification.  The linked blocker MAPREDUCE-4162 will use the method.  Specifically, it's used to get the address a proxy is connected to in order to correctly set the service for host-based tokens.
                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273208#comment-13273208 ] 

Hudson commented on HADOOP-8373:
--------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #253 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/253/])
    HADOOP-8373. Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336297)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336297
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryInvocationHandler.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcInvocationHandler.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java

                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271501#comment-13271501 ] 

Robert Joseph Evans commented on HADOOP-8373:
---------------------------------------------

The patch looks good to me.  My only concern is that it looks like you added in a test that was not a part of the original code.  I would be great to have that test on more then just branch-0.23  Other then that +1. It compiles and passed my tests.

I'll check the current patch into branch-0.23 now, and assuming you get a patch up for the test I'll throw that into trunk/branch-2 too.
                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273226#comment-13273226 ] 

Hudson commented on HADOOP-8373:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1040 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1040/])
    HADOOP-8373. Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299)

     Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java

                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-8373:
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0.0
                   2.0.0
                   0.23.3
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Thanks for the fix Daryn,

I put the full patch into branch-0.23, and pulled in just the new test into trunk and branch-2.
                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271538#comment-13271538 ] 

Hadoop QA commented on HADOOP-8373:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12526174/TestRPC.trunk.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/966//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/966//console

This message is automatically generated.
                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271659#comment-13271659 ] 

Hudson commented on HADOOP-8373:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2229 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2229/])
    HADOOP-8373. Port RPC.getServerAddress to 0.23 (Daryn Sharp via bobby) (Revision 1336299)

     Result = ABORTED
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336299
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java

                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8373.patch, TestRPC.trunk.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8373) Port RPC.getServerAddress to 0.23

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271499#comment-13271499 ] 

Hadoop QA commented on HADOOP-8373:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12526172/HADOOP-8373.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/965//console

This message is automatically generated.
                
> Port RPC.getServerAddress to 0.23
> ---------------------------------
>
>                 Key: HADOOP-8373
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8373
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.23.3
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8373.patch
>
>
> {{RPC.getServerAddress}} was introduced in trunk/2.0 as part of larger HA changes.  0.23 does not have HA, but this non-HA specific method is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira