You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/09/26 13:50:53 UTC

[GitHub] spark pull request #21234: [SPARK-24124] Spark history server should create ...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21234#discussion_r220570611
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -18,6 +18,8 @@
     package org.apache.spark.deploy.history
     
     import java.io.{File, FileNotFoundException, IOException}
    +import java.nio.file.Files
    +import java.nio.file.attribute.PosixFilePermissions
    --- End diff --
    
    PS this stop it from working on Windows; see https://github.com/apache/spark/pull/22520


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org