You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by or...@apache.org on 2015/11/25 14:05:28 UTC
svn commit: r1716374 - in /qpid/java/trunk:
qpid-test-utils/src/main/java/org/apache/qpid/test/utils/TCPTunneler.java
systests/src/test/java/org/apache/qpid/server/AbruptClientDisconnectTest.java
Author: orudyy
Date: Wed Nov 25 13:05:27 2015
New Revision: 1716374
URL: http://svn.apache.org/viewvc?rev=1716374&view=rev
Log:
QPID-6869: Address remaining review comments from Lorenz Quack
Modified:
qpid/java/trunk/qpid-test-utils/src/main/java/org/apache/qpid/test/utils/TCPTunneler.java
qpid/java/trunk/systests/src/test/java/org/apache/qpid/server/AbruptClientDisconnectTest.java
Modified: qpid/java/trunk/qpid-test-utils/src/main/java/org/apache/qpid/test/utils/TCPTunneler.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/qpid-test-utils/src/main/java/org/apache/qpid/test/utils/TCPTunneler.java?rev=1716374&r1=1716373&r2=1716374&view=diff
==============================================================================
--- qpid/java/trunk/qpid-test-utils/src/main/java/org/apache/qpid/test/utils/TCPTunneler.java (original)
+++ qpid/java/trunk/qpid-test-utils/src/main/java/org/apache/qpid/test/utils/TCPTunneler.java Wed Nov 25 13:05:27 2015
@@ -48,12 +48,12 @@ public class TCPTunneler
private final TCPWorker _tcpWorker;
private final ExecutorService _executor;
- public TCPTunneler(final int localHost, final String remotetHost,
+ public TCPTunneler(final int localPort, final String remoteHost,
final int remotePort,
final int numberOfConcurrentClients)
{
_executor = Executors.newFixedThreadPool(numberOfConcurrentClients * 2 + 1);
- _tcpWorker = new TCPWorker(localHost, remotetHost, remotePort, _executor);
+ _tcpWorker = new TCPWorker(localPort, remoteHost, remotePort, _executor);
}
public void start() throws IOException
@@ -99,7 +99,7 @@ public class TCPTunneler
void clientDisconnected(InetSocketAddress clientAddress);
}
- public static class TCPWorker implements Runnable
+ private static class TCPWorker implements Runnable
{
private final String _remoteHost;
private final int _remotePort;
@@ -366,7 +366,7 @@ public class TCPTunneler
}
- public static class SocketTunnel
+ private static class SocketTunnel
{
private final Socket _clientSocket;
private final Socket _serverSocket;
@@ -475,7 +475,7 @@ public class TCPTunneler
}
}
- public static class StreamForwarder implements Runnable
+ private static class StreamForwarder implements Runnable
{
private static final int BUFFER_SIZE = 4096;
Modified: qpid/java/trunk/systests/src/test/java/org/apache/qpid/server/AbruptClientDisconnectTest.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/systests/src/test/java/org/apache/qpid/server/AbruptClientDisconnectTest.java?rev=1716374&r1=1716373&r2=1716374&view=diff
==============================================================================
--- qpid/java/trunk/systests/src/test/java/org/apache/qpid/server/AbruptClientDisconnectTest.java (original)
+++ qpid/java/trunk/systests/src/test/java/org/apache/qpid/server/AbruptClientDisconnectTest.java Wed Nov 25 13:05:27 2015
@@ -354,6 +354,7 @@ public class AbruptClientDisconnectTest
catch (InterruptedException e)
{
_thread.interrupt();
+ Thread.currentThread().interrupt();
}
}
}
@@ -451,6 +452,7 @@ public class AbruptClientDisconnectTest
catch (InterruptedException e)
{
_thread.interrupt();
+ Thread.currentThread().interrupt();
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org