You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "pivotal-jbarrett (GitHub)" <gi...@apache.org> on 2018/10/30 06:25:16 UTC
[GitHub] [geode-native] pivotal-jbarrett opened pull request #387:
GEODE-5025: Fixes template visiblity when linked with executables.
[ Full content available at: https://github.com/apache/geode-native/pull/387 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mreddington commented on pull request #387:
GEODE-5025: Fixes template visiblity when linked with executables.
Posted by "mreddington (GitHub)" <gi...@apache.org>.
If you have to include an internal namespace in a public namespace, if you have to ship internal headers along with the public API headers, then your internal is public. I recommend we move these classes into the public API space.
[ Full content available at: https://github.com/apache/geode-native/pull/387 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #387:
GEODE-5025: Fixes template visiblity when linked with executables.
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
Do these belong in a header file? I believe we should lose them. If not, at least make the usage consistent and get rid of `internal::` prior to references to the types we're using.
[ Full content available at: https://github.com/apache/geode-native/pull/387 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#387: GEODE-5025: Fixes template visiblity when linked with executables.
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
The use of "internal" namespaces and classes in public headers is consistent with other C++ libraries, most notably Boost. Boost uses the namespace "detail" for detail specific/internal headers.
[ Full content available at: https://github.com/apache/geode-native/pull/387 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey closed pull request #387:
GEODE-5025: Fixes template visiblity when linked with executables.
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
[ pull request closed by pdxcodemonkey ]
[ Full content available at: https://github.com/apache/geode-native/pull/387 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org