[GitHub] sven-lange-last opened a new pull request #3485: Action time limit test cleanup

[GitBox <gi...@apache.org>]

sven-lange-last opened a new pull request #3485: Action time limit test cleanup
URL: https://github.com/apache/incubator-openwhisk/pull/3485
 
 
   Improving tests around (maximum) action time limit
   
   ## Description
   
   Major goals of this pull request:
   * Some tests use a Node.js based action `timeout.js` which uses a busy-wait loop keeping one full CPU busy while waiting. Introduce a new CPU-friendly sleep action `sleep.js` and replace `timeout.js`. This should make the affected tests faster or less brittle if they run on the same system where the test action is running.
   * #3379 introduced configurable maximum action time limits. When changing the maximum action time limit to a value higher than 5 minutes, the `MaxActionDurationTest` starts to fail because it contains hard-coded time limits. This PR Introduces new test actions `sleep.jar` (Java including source) and `sleep.py` (Python) which sleep as many milliseconds as specified during invocation.
   * Improve tests around (maximum) action time limit.
   * Move action creation tests with limits to `ActionLimitsTests` suite to have these tests in once place.
   
   ## Related issue and scope
   See #3379.
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [X] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [X] Bug fix (generally a non-breaking change which closes an issue).
   - [X] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [X] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [X] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services