[GitHub] [kafka] niket-goel commented on a change in pull request #11135: KAFKA-13143 Remove HandleMetadata from ControllerAPis as metadata is not completely implemented on KRaft controllers

[GitBox <gi...@apache.org>]

niket-goel commented on a change in pull request #11135:
URL: https://github.com/apache/kafka/pull/11135#discussion_r677815515



##########
File path: clients/src/main/resources/common/message/MetadataRequest.json
##########
@@ -16,9 +16,9 @@
 {
   "apiKey": 3,
   "type": "request",
-  "listeners": ["zkBroker", "broker", "controller"],
+  "listeners": ["zkBroker", "broker"],
   "name": "MetadataRequest",
-  "validVersions": "0-11",
+  "validVersions": "0-12",

Review comment:
       I am not sure if just modifying the valid versions bumps the version number (or if we want to bump the version at all)

##########
File path: core/src/test/scala/unit/kafka/server/ControllerApisTest.scala
##########
@@ -145,6 +145,14 @@ class ControllerApisTest {
     authorizer
   }
 
+  @Test
+  def testHanldleMetadata(): Unit = {
+    val caught = assertThrows(classOf[ApiException], () => createControllerApis(
+      None, new MockController.Builder().build()).

Review comment:
       I think I might have found an NPE. createControllerApis allows for Option[authorizer], however fails with an NPE if None is passed as an authorizer. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org