[GitHub] [flink] AHeise commented on a change in pull request #10482: [Flink-11956] Unshade s3 filesystems

[GitBox <gi...@apache.org>]

AHeise commented on a change in pull request #10482: [Flink-11956] Unshade s3 filesystems
URL: https://github.com/apache/flink/pull/10482#discussion_r356996925
 
 

 ##########
 File path: flink-filesystems/flink-s3-fs-base/pom.xml
 ##########
 @@ -46,14 +46,14 @@ under the License.
 			<scope>provided</scope>
 		</dependency>
 
-		<!-- Hadoop's file system abstraction (bundled) -->
-		<dependency>
-			<groupId>org.apache.flink</groupId>
-			<artifactId>flink-fs-hadoop-shaded</artifactId>
-			<version>${project.version}</version>
-		</dependency>
-
-		<!-- The Hadoop file system adapter classes (bundled) -->
+        <!-- Hadoop's file system abstraction (bundled) -->
+        <dependency>
+            <groupId>org.apache.hadoop</groupId>
+            <artifactId>hadoop-common</artifactId>
 
 Review comment:
   > what's this change about? If the s3 filesystems no longer depend on `flink-fs-hadoop-shaded`, why are we touching `flink-fs-hadoop-shaded` at all?
   > Is `flink-fs-hadoop-shaded` even useful on it's own? If not (i.e., it always being bundled by some other functional component) then the module itself could probably just be removed.
   
   You are right that the changes to `flink-fs-hadoop-shaded` should be reverted. If we unshade all modules, it can be completely removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services