[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3681: Validate disk offering IOPS normal and maximum read/write values

[GitBox <gi...@apache.org>]

GabrielBrascher opened a new pull request #3681: Validate disk offering IOPS normal and maximum read/write values
URL: https://github.com/apache/cloudstack/pull/3681
 
 
   ## Description
   
   When creating a new disk offering ('createDiskOffering' command on API) one can set _normal_ IOPS (write/read) higher than the maximum, breaking the logics on the disk offerings.
   
   This PR adds verifications ensuring that _normal_ read/write cannot be greater than _maximum_ read/write. Additionally, it was added a global settings 'iops.maximum.rate.length' to ensure realistic values for the IOPS burst length (seconds).
   
   The global settings 'iops.maximum.rate.length' configures the maximum IOPS read/write length; thus, preventing irrealistic values for a disk offering (e.g. hours or days of burst IOPS). The default value is 0 (zero), allowing any IOPS maximum rate length; thus keeping backward compatibility and not affecting any environment configuration after upgrades.
   
   # Example:
   One can set the 'iops.maximum.rate.length' to '3600' (seconds); once the parameter is updated on the management server it will not be possible to create disk offerings with IOPS length higher than 3600 seconds (60 minutes).
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)g

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services