You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/14 01:37:35 UTC
[GitHub] [spark] ulysses-you opened a new pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
ulysses-you opened a new pull request #31830:
URL: https://github.com/apache/spark/pull/31830
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add `SQL Properties` ins SQL tab that show the modified configs with sql execution.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
For SQL user, it's very common to add some config to optimize sql. Within a script, it would look like this
```
set k1=v1;
set k2=v2;
set ...
INSERT INTO TABLE t1
SELECT ...
```
It's hard to find the configs used by sql without the raw sql string. Current UI provide a `Environment` tab that we can only get some global initial config, however it's not enough.
Some use case:
* Jar based job, we might set sql config many times due to many sql execution.
* SQL server e.g. (SparkThriftServer), we might execute thousands scripts every day with different session.
We expect a feature that can list the modified configs which could affect the sql execution.
Here is a simple example with `./bin/spark-sql`:
```
set spark.sql.autoBroadcastJoinThreshold = -1;
set spark.sql.adaptive.enabled=false;
SELECT 1;
```
The screen snapshot of SQL tab
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, the UI cahgned with the `SQL Properties` in SQL tab.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Add test and munual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-805597062
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136431/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-805597062
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136431/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-907969572
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47353/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-799928516
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136090/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-918856538
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143230/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-979655178
**[Test build #145643 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145643/testReport)** for PR 31830 at commit [`265c525`](https://github.com/apache/spark/commit/265c5253f0e47ba5e617fc86ec08c7daad7b27d5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #31830:
URL: https://github.com/apache/spark/pull/31830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r594635612
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3986,4 +3986,13 @@ class SQLConf extends Serializable with Logging {
def isModifiable(key: String): Boolean = {
sqlConfEntries.containsKey(key) && !staticConfKeys.contains(key)
}
+
+ /**
+ * Return all non-static configuration
+ */
+ def getAllNonStaticConfs(): Map[String, String] = {
Review comment:
When do we need to declare this additional function? This PR shows the modified configs by comparing the value between `sessionState.conf` and `globalConfigs`. For the static configs, the values are the same already, aren't they?
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3986,4 +3986,13 @@ class SQLConf extends Serializable with Logging {
def isModifiable(key: String): Boolean = {
sqlConfEntries.containsKey(key) && !staticConfKeys.contains(key)
}
+
+ /**
+ * Return all non-static configuration
+ */
+ def getAllNonStaticConfs(): Map[String, String] = {
Review comment:
When do we need this additional function? This PR shows the modified configs by comparing the value between `sessionState.conf` and `globalConfigs`. For the static configs, the values are the same already, aren't they?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-801756193
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40786/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-918725293
**[Test build #143230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143230/testReport)** for PR 31830 at commit [`265c525`](https://github.com/apache/spark/commit/265c5253f0e47ba5e617fc86ec08c7daad7b27d5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-907974478
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47353/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-908086031
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142850/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-907974478
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47353/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-845652568
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43304/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-845645932
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43304/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-979699594
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50114/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-979697013
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50114/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r594827198
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3986,4 +3986,13 @@ class SQLConf extends Serializable with Logging {
def isModifiable(key: String): Boolean = {
sqlConfEntries.containsKey(key) && !staticConfKeys.contains(key)
}
+
+ /**
+ * Return all non-static configuration
+ */
+ def getAllNonStaticConfs(): Map[String, String] = {
Review comment:
Removed it since it's redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r594830079
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala
##########
@@ -46,6 +46,7 @@ case class SparkListenerSQLExecutionStart(
description: String,
details: String,
physicalPlanDescription: String,
+ modifiedConfigs: Map[String, String],
Review comment:
Adding a field here will break the backward compatibility. The history server can't load the previous event logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r594831027
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala
##########
@@ -87,6 +87,11 @@ object SQLExecution {
val planDescriptionMode =
ExplainMode.fromString(sparkSession.sessionState.conf.uiExplainMode)
+ val globalConfigs = sparkSession.sharedState.conf.getAll.toMap
+ val modifiedConfigs = sparkSession.sessionState.conf.getAllConfs
+ .filterNot(kv => globalConfigs.get(kv._1).contains(kv._2))
Review comment:
How much time will be spent on getting the modifiedConfigs here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-918751934
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47733/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-918751955
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47733/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-979652210
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-845596499
**[Test build #138780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138780/testReport)** for PR 31830 at commit [`5fd29ca`](https://github.com/apache/spark/commit/5fd29ca693f255010c7ccb6ca3d62aa2c9386fbe).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-799706040
cc @gengliangwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r594844688
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala
##########
@@ -87,6 +87,11 @@ object SQLExecution {
val planDescriptionMode =
ExplainMode.fromString(sparkSession.sessionState.conf.uiExplainMode)
+ val globalConfigs = sparkSession.sharedState.conf.getAll.toMap
+ val modifiedConfigs = sparkSession.sessionState.conf.getAllConfs
+ .filterNot(kv => globalConfigs.get(kv._1).contains(kv._2))
Review comment:
Beanmark locally, its quite fast (0.0x ms) since the filter option just cost `O(N)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-907955306
**[Test build #142850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142850/testReport)** for PR 31830 at commit [`265c525`](https://github.com/apache/spark/commit/265c5253f0e47ba5e617fc86ec08c7daad7b27d5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-979770707
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145643/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-805476978
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41015/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-980497803
thank you all !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-979655178
**[Test build #145643 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145643/testReport)** for PR 31830 at commit [`265c525`](https://github.com/apache/spark/commit/265c5253f0e47ba5e617fc86ec08c7daad7b27d5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-979699594
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50114/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-979769231
**[Test build #145643 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145643/testReport)** for PR 31830 at commit [`265c525`](https://github.com/apache/spark/commit/265c5253f0e47ba5e617fc86ec08c7daad7b27d5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-979677703
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50114/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #31830:
URL: https://github.com/apache/spark/pull/31830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-918717110
aslo cc @HyukjinKwon @sarutak what do you think about this feature ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #31830:
URL: https://github.com/apache/spark/pull/31830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-845744692
**[Test build #138780 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138780/testReport)** for PR 31830 at commit [`5fd29ca`](https://github.com/apache/spark/commit/5fd29ca693f255010c7ccb6ca3d62aa2c9386fbe).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-907906000
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r594843557
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala
##########
@@ -46,6 +46,7 @@ case class SparkListenerSQLExecutionStart(
description: String,
details: String,
physicalPlanDescription: String,
+ modifiedConfigs: Map[String, String],
Review comment:
That's a good point, seems a better approach is add an another event.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-918751955
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47733/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-918856538
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143230/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-908155399
@dongjoon-hyun Are you ok with this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-908078401
**[Test build #142850 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142850/testReport)** for PR 31830 at commit [`265c525`](https://github.com/apache/spark/commit/265c5253f0e47ba5e617fc86ec08c7daad7b27d5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r600125011
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala
##########
@@ -46,6 +46,7 @@ case class SparkListenerSQLExecutionStart(
description: String,
details: String,
physicalPlanDescription: String,
+ modifiedConfigs: Map[String, String],
Review comment:
yeah, revert the new event which seems quite hack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r597858470
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala
##########
@@ -46,6 +46,7 @@ case class SparkListenerSQLExecutionStart(
description: String,
details: String,
physicalPlanDescription: String,
+ modifiedConfigs: Map[String, String],
Review comment:
Can we resolve it by moving the new field to the tail of the class constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-798871084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r594826770
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
##########
@@ -157,6 +161,45 @@ class SQLExecutionSuite extends SparkFunSuite {
}
}
}
+
+ test("SPARK-34735: Add modified configs for SQL execution in UI") {
+ val spark = SparkSession.builder()
+ .master("local[*]")
+ .appName("test")
+ .config("k1", "v1")
+ .getOrCreate()
+
+ try {
+ val index = new AtomicInteger(0)
+ spark.sparkContext.addSparkListener(new SparkListener {
+ override def onOtherEvent(event: SparkListenerEvent): Unit = event match {
+ case start: SparkListenerSQLExecutionStart =>
+ if (index.get() == 0 && hasProject(start)) {
+ assert(!start.modifiedConfigs.contains("k1"))
+ index.incrementAndGet()
+ } else if (index.get() == 1 && hasProject(start)) {
+ assert(start.modifiedConfigs.contains("k2"))
+ assert(start.modifiedConfigs("k2") == "v2")
+ assert(start.modifiedConfigs.contains("redaction.password"))
+ assert(start.modifiedConfigs("redaction.password") == REDACTION_REPLACEMENT_TEXT)
Review comment:
thank you @dongjoon-hyun , the redaction is missed before and now is enable. This test is for your request about redaction, please let me know if there miss anything else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-805503802
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41015/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-908086031
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142850/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-845635070
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43304/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-845746112
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138780/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-907955306
**[Test build #142850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142850/testReport)** for PR 31830 at commit [`265c525`](https://github.com/apache/spark/commit/265c5253f0e47ba5e617fc86ec08c7daad7b27d5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r594636321
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/ExecutionPage.scala
##########
@@ -90,7 +91,6 @@ class ExecutionPage(parent: SQLTab) extends WebUIPage("execution") with Logging
request, s"Details for Query $executionId", content, parent)
}
-
Review comment:
Shall we revert this removal?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-801755108
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136204/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r600124482
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLJsonProtocolSuite.scala
##########
@@ -28,28 +29,46 @@ import org.apache.spark.util.JsonProtocol
class SQLJsonProtocolSuite extends SparkFunSuite with LocalSparkSession {
test("SparkPlanGraph backward compatibility: metadata") {
- val SQLExecutionStartJsonString =
- """
- |{
- | "Event":"org.apache.spark.sql.execution.ui.SparkListenerSQLExecutionStart",
- | "executionId":0,
- | "description":"test desc",
- | "details":"test detail",
- | "physicalPlanDescription":"test plan",
- | "sparkPlanInfo": {
- | "nodeName":"TestNode",
- | "simpleString":"test string",
- | "children":[],
- | "metadata":{},
- | "metrics":[]
- | },
- | "time":0
- |}
+ Seq(true, false).foreach { newExecutionStartEvent =>
+ val event = if (newExecutionStartEvent) {
+ "org.apache.spark.sql.execution.ui.SparkListenerSQLExecutionStart"
+ } else {
+ "org.apache.spark.sql.execution.OldVersionSQLExecutionStart"
+ }
+ val SQLExecutionStartJsonString =
+ s"""
+ |{
+ | "Event":"$event",
+ | "executionId":0,
+ | "description":"test desc",
+ | "details":"test detail",
+ | "physicalPlanDescription":"test plan",
+ | "sparkPlanInfo": {
+ | "nodeName":"TestNode",
+ | "simpleString":"test string",
+ | "children":[],
+ | "metadata":{},
+ | "metrics":[]
+ | },
+ | "time":0,
+ | "modifiedConfigs": {
+ | "k1":"v1"
+ | }
+ |}
""".stripMargin
- val reconstructedEvent = JsonProtocol.sparkEventFromJson(parse(SQLExecutionStartJsonString))
- val expectedEvent = SparkListenerSQLExecutionStart(0, "test desc", "test detail", "test plan",
- new SparkPlanInfo("TestNode", "test string", Nil, Map(), Nil), 0)
- assert(reconstructedEvent == expectedEvent)
+
+ val reconstructedEvent = JsonProtocol.sparkEventFromJson(parse(SQLExecutionStartJsonString))
+ if (newExecutionStartEvent) {
+ val expectedEvent = SparkListenerSQLExecutionStart(0, "test desc", "test detail",
+ "test plan", new SparkPlanInfo("TestNode", "test string", Nil, Map(), Nil), 0,
+ Map("k1" -> "v1"))
+ assert(reconstructedEvent == expectedEvent)
+ } else {
+ val expectedOldEvent = OldVersionSQLExecutionStart(0, "test desc", "test detail",
+ "test plan", new SparkPlanInfo("TestNode", "test string", Nil, Map(), Nil), 0)
+ assert(reconstructedEvent == expectedOldEvent)
Review comment:
this test ensure we keep the backward compatibility @gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-798871403
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136041/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #31830:
URL: https://github.com/apache/spark/pull/31830#discussion_r594827038
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/ExecutionPage.scala
##########
@@ -90,7 +91,6 @@ class ExecutionPage(parent: SQLTab) extends WebUIPage("execution") with Logging
request, s"Details for Query $executionId", content, parent)
}
-
Review comment:
yeah, removed it to make this PR clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-805454834
**[Test build #136431 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136431/testReport)** for PR 31830 at commit [`6fae550`](https://github.com/apache/spark/commit/6fae550494abec28ca36dfc2cc61a377fa6af754).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #31830:
URL: https://github.com/apache/spark/pull/31830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-805454834
**[Test build #136431 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136431/testReport)** for PR 31830 at commit [`6fae550`](https://github.com/apache/spark/commit/6fae550494abec28ca36dfc2cc61a377fa6af754).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-805493787
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41015/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-805594723
**[Test build #136431 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136431/testReport)** for PR 31830 at commit [`6fae550`](https://github.com/apache/spark/commit/6fae550494abec28ca36dfc2cc61a377fa6af754).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-845746112
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138780/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-845596499
**[Test build #138780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138780/testReport)** for PR 31830 at commit [`5fd29ca`](https://github.com/apache/spark/commit/5fd29ca693f255010c7ccb6ca3d62aa2c9386fbe).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-805503802
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41015/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-798871084
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40624/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-845652568
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43304/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-918845262
**[Test build #143230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143230/testReport)** for PR 31830 at commit [`265c525`](https://github.com/apache/spark/commit/265c5253f0e47ba5e617fc86ec08c7daad7b27d5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-918725293
**[Test build #143230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143230/testReport)** for PR 31830 at commit [`265c525`](https://github.com/apache/spark/commit/265c5253f0e47ba5e617fc86ec08c7daad7b27d5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-918748709
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47733/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-979770707
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145643/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #31830:
URL: https://github.com/apache/spark/pull/31830#issuecomment-979962481
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org