[GitHub] [pulsar] mattisonchao opened a new pull request, #19365: [cleanup][txn] Cleanup duplicated logic.

["mattisonchao (via GitHub)" <gi...@apache.org>]

mattisonchao opened a new pull request, #19365:
URL: https://github.com/apache/pulsar/pull/19365

   ### Motivation
   
   I found some logic that can be cleaned up after reading this part of the code.
   
   ### Modifications
   
   - Remove meaningless `.thenCompose(ignored -> CompletableFuture.completedFuture(null))`, cause original future is return `CompletableFuture<Void>`.
   - Remove `synchronized` blocks, because `registerPartitionMap` and `registerSubscriptionMap` is concurrent hashmap.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao closed pull request #19365: [cleanup][txn] Cleanup duplicated logic.

["mattisonchao (via GitHub)" <gi...@apache.org>]

mattisonchao closed pull request #19365: [cleanup][txn] Cleanup duplicated logic.
URL: https://github.com/apache/pulsar/pull/19365


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org