You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2023/06/27 16:18:09 UTC
[GitHub] [incubator-uniffle] slfan1989 commented on a diff in pull request #968: [#768] [Follow Up] feat(cli): Cli method for blacklist update.
slfan1989 commented on code in PR #968:
URL: https://github.com/apache/incubator-uniffle/pull/968#discussion_r1244017612
##########
cli/src/main/java/org/apache/uniffle/cli/UniffleAdminCLI.java:
##########
@@ -49,13 +49,13 @@ public UniffleAdminCLI(String shortPrefix, String longPrefix) {
false, "Help for the Uniffle Admin CLI.");
coordinatorHost = new Option(shortPrefix + "s", longPrefix + "coordinatorHost",
true, "This is coordinator server host.");
- coordPort = new Option(shortPrefix + "p", longPrefix + "port",
+ coordinatorPort = new Option(shortPrefix + "p", longPrefix + "port",
true, "This is coordinator server port.");
- ssl = new Option(null, longPrefix + "ssl", false, "use SSL");
+ ssl = new Option("l", longPrefix + "ssl", false, "use SSL");
Review Comment:
@advancedxy Thank you for your help in reviewing the code! I tried to remove the short option and test it in the test environment. I think your feedback is accurate. It is better to use the long option (ssl).
<img width="688" alt="image" src="https://github.com/apache/incubator-uniffle/assets/55643692/7030aae9-861e-45cc-b356-632c9d8fcb0c">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org