You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "guptakaran-01 (via GitHub)" <gi...@apache.org> on 2026/01/19 16:31:06 UTC
[PR] Added test for isAllLowerCase and isAllUpperCase in StringUtilTest [commons-lang]
guptakaran-01 opened a new pull request, #1573:
URL: https://github.com/apache/commons-lang/pull/1573
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated!
Before you push a pull request, review this list:
- [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
- [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added test for isAllLowerCase and isAllUpperCase in StringUtilTest [commons-lang]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1573:
URL: https://github.com/apache/commons-lang/pull/1573#issuecomment-3769602393
-1 and closing: This PR doesn't improve the test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added test for isAllLowerCase and isAllUpperCase in StringUtilTest [commons-lang]
Posted by "guptakaran-01 (via GitHub)" <gi...@apache.org>.
guptakaran-01 commented on PR #1573:
URL: https://github.com/apache/commons-lang/pull/1573#issuecomment-3769344002
Hi, this is my first contribution to Apache Commons.
I added additional unit test coverage for StringUtils by extending existing test cases in StringUtilsTest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added test for isAllLowerCase and isAllUpperCase in StringUtilTest [commons-lang]
Posted by "guptakaran-01 (via GitHub)" <gi...@apache.org>.
guptakaran-01 commented on PR #1573:
URL: https://github.com/apache/commons-lang/pull/1573#issuecomment-3771036113
Thank you for the review.
I understand the feedback — the added test does not meaningfully increase coverage beyond existing cases.
I appreciate the guidance and will be more careful in identifying gaps in test coverage in future contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added test for isAllLowerCase and isAllUpperCase in StringUtilTest [commons-lang]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #1573: Added test for isAllLowerCase and isAllUpperCase in StringUtilTest
URL: https://github.com/apache/commons-lang/pull/1573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org