You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/04/10 19:18:39 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #40726: [SPARK-42382][BUILD] Upgrade `cyclonedx-maven-plugin` to 2.7.6
dongjoon-hyun opened a new pull request, #40726:
URL: https://github.com/apache/spark/pull/40726
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40726: [SPARK-42382][BUILD] Upgrade `cyclonedx-maven-plugin` to 2.7.6
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40726:
URL: https://github.com/apache/spark/pull/40726#issuecomment-1502587494
late LGTM ~ Thanks @dongjoon-hyun and all ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40726: [SPARK-42382][BUILD] Upgrade `cyclonedx-maven-plugin` to 2.7.6
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40726:
URL: https://github.com/apache/spark/pull/40726#issuecomment-1502483678
Hm, for some reasons, it shows @LuciferYang as a primary author. I manually changed it to @dongjoon-hyun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40726: [SPARK-42382][BUILD] Upgrade `cyclonedx-maven-plugin` to 2.7.6
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40726:
URL: https://github.com/apache/spark/pull/40726#issuecomment-1502484690
Oh, it was intentional https://github.com/apache/spark/pull/40726#pullrequestreview-1378012264, but thank you!
Thank you, @HyukjinKwon and @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] steveloughran commented on pull request #40726: [SPARK-42382][BUILD] Upgrade `cyclonedx-maven-plugin` to 2.7.6
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran commented on PR #40726:
URL: https://github.com/apache/spark/pull/40726#issuecomment-1503090288
this working OK on the latest maven releases that homebrew is pushing out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40726: [SPARK-42382][BUILD] Upgrade `cyclonedx-maven-plugin` to 2.7.6
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40726:
URL: https://github.com/apache/spark/pull/40726#issuecomment-1502427149
Could you review this PR, @viirya ? I verified manually.
```
$ ls -alt
total 67688
-rw-r--r--@ 1 dongjoon staff 1955 Apr 10 15:27 maven-metadata-local.xml
-rw-r--r--@ 1 dongjoon staff 492 Apr 10 15:27 _remote.repositories
-rw-r--r--@ 1 dongjoon staff 4451845 Apr 10 15:27 spark-core_2.12-3.5.0-SNAPSHOT-javadoc.jar
-rw-r--r--@ 1 dongjoon staff 362584 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT-cyclonedx.json
-rw-r--r--@ 1 dongjoon staff 312338 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT-cyclonedx.xml
-rw-r--r--@ 1 dongjoon staff 1423015 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT-test-sources.jar
-rw-r--r--@ 1 dongjoon staff 2919170 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT-sources.jar
-rw-r--r--@ 1 dongjoon staff 8078262 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT-tests.jar
-rw-r--r--@ 1 dongjoon staff 14038165 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT.jar
-rw-r--r--@ 1 dongjoon staff 44355 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT.pom
drwxr-xr-x@ 4 dongjoon staff 128 Apr 10 14:56 ..
drwxr-xr-x@ 12 dongjoon staff 384 Apr 10 14:56 .
$ head spark-core_2.12-3.5.0-SNAPSHOT-cyclonedx.xml
<?xml version="1.0" encoding="UTF-8"?>
<bom serialNumber="urn:uuid:14185927-0ca0-4589-92aa-268c9c81873d" version="1" xmlns="http://cyclonedx.org/schema/bom/1.4">
<metadata>
<timestamp>2023-04-10T22:26:52Z</timestamp>
<tools>
<tool>
<vendor>OWASP Foundation</vendor>
<name>CycloneDX Maven plugin makeBom compile+provided+runtime+system</name>
<version>2.7.6</version>
<hashes>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40726: [SPARK-42382][BUILD] Upgrade `cyclonedx-maven-plugin` to 2.7.6
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40726:
URL: https://github.com/apache/spark/pull/40726#issuecomment-1502375359
R failure on AppVeyor is irrelevant to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40726: [SPARK-42382][BUILD] Upgrade `cyclonedx-maven-plugin` to 2.7.6
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40726:
URL: https://github.com/apache/spark/pull/40726#issuecomment-1503684409
To @steveloughran , this is done independently from Maven.
I verified in Apache ORC and Spark community only for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40726: [SPARK-42382][BUILD] Upgrade `cyclonedx-maven-plugin` to 2.7.6
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40726: [SPARK-42382][BUILD] Upgrade `cyclonedx-maven-plugin` to 2.7.6
URL: https://github.com/apache/spark/pull/40726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40726: [SPARK-42382][BUILD] Upgrade `cyclonedx-maven-plugin` to 2.7.6
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40726:
URL: https://github.com/apache/spark/pull/40726#issuecomment-1502482929
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org