You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2021/01/03 09:38:32 UTC

[GitHub] [struts] lukaszlenart opened a new pull request #466: [WW-5056] Accepts dashes in param names

lukaszlenart opened a new pull request #466:
URL: https://github.com/apache/struts/pull/466


   Implements [WW-5056](https://issues.apache.org/jira/browse/WW-5056)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] lukaszlenart merged pull request #466: [WW-5056] Accepts dashes in param names

Posted by GitBox <gi...@apache.org>.
lukaszlenart merged pull request #466:
URL: https://github.com/apache/struts/pull/466


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] coveralls commented on pull request #466: [WW-5056] Accepts dashes in param names

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #466:
URL: https://github.com/apache/struts/pull/466#issuecomment-753597021


   
   [![Coverage Status](https://coveralls.io/builds/36045229/badge)](https://coveralls.io/builds/36045229)
   
   Coverage remained the same at 49.823% when pulling **23169941e723ca1a86f9c270b347a76f8c186fc7 on WW-5056-allows-dash** into **dcc53aebf983f6c0a48932262facb81f5d82815c on master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] sepe81 commented on a change in pull request #466: [WW-5056] Accepts dashes in param names

Posted by GitBox <gi...@apache.org>.
sepe81 commented on a change in pull request #466:
URL: https://github.com/apache/struts/pull/466#discussion_r551435370



##########
File path: core/src/test/java/com/opensymphony/xwork2/security/DefaultAcceptedPatternsCheckerTest.java
##########
@@ -97,6 +98,35 @@ public void testUnderscoreInParamName() {
         assertTrue("Param with underscore wasn't accepted!", actual.isAccepted());
     }
 
+    public void testDashInParamName() {
+        // given
+        AcceptedPatternsChecker checker = new DefaultAcceptedPatternsChecker();
+
+        // when
+        AcceptedPatternsChecker.IsAccepted actual = checker.isAccepted("mapParam['param-1']");
+
+        // then
+        assertTrue("Param with dasf wasn't accepted!", actual.isAccepted());

Review comment:
       ```suggestion
           assertTrue("Param with dash wasn't accepted!", actual.isAccepted());
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] coveralls edited a comment on pull request #466: [WW-5056] Accepts dashes in param names

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #466:
URL: https://github.com/apache/struts/pull/466#issuecomment-753597021


   
   [![Coverage Status](https://coveralls.io/builds/36071419/badge)](https://coveralls.io/builds/36071419)
   
   Coverage remained the same at 49.823% when pulling **474e281390bb141d610a8d6eb2269fff49a8ddf5 on WW-5056-allows-dash** into **dcc53aebf983f6c0a48932262facb81f5d82815c on master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org