You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/03/08 15:42:10 UTC

[GitHub] [daffodil] tuxji commented on pull request #496: Update jackson-core to 2.11.4

tuxji commented on pull request #496:
URL: https://github.com/apache/daffodil/pull/496#issuecomment-792840794


   I agree we need a checklist.  I just realized I overlooked that daffodil-cli/bin.NOTICE still mentions jackson-core's old version number.  The review criteria should include:
   
   1) A determination whether the version update is a patch, minor, or major update.  Major updates need more stringent review criteria than the other updates, at least a manual reading of the library's release notes / changelog to check for API changes.
   
   2) How to update any files like daffodil-cli/bin.NOTICE.  Should we push a commit to each and every pull request updating that page AND squash the commits together before merging each pull request?  Or update the daffodil-cli/bin.NOTICE file once in one last manually made pull request?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org