You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/02/22 08:13:05 UTC
Review Request 43823: Updated `/tasks` master endpoint to use jsonify.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43823/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Updated `/tasks` master endpoint to use jsonify.
Diffs
-----
src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317
Diff: https://reviews.apache.org/r/43823/diff/
Testing
-------
make check. Also verified that this endpoint is covered by the unit tests.
Thanks,
Neil Conway
Re: Review Request 43823: Updated `/tasks` master endpoint to use
jsonify.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43823/#review120292
-----------------------------------------------------------
Ship it!
Ship It!
- Klaus Ma
On Feb. 22, 2016, 3:13 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43823/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 3:13 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `/tasks` master endpoint to use jsonify.
>
>
> Diffs
> -----
>
> src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317
>
> Diff: https://reviews.apache.org/r/43823/diff/
>
>
> Testing
> -------
>
> make check. Also verified that this endpoint is covered by the unit tests.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43823: Updated `/tasks` master endpoint to use
jsonify.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43823/#review123515
-----------------------------------------------------------
Ship it!
src/master/http.cpp (line 1950)
<https://reviews.apache.org/r/43823/#comment185747>
Committed with `this` removed.
- Michael Park
On March 11, 2016, 10:10 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43823/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 10:10 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `/tasks` master endpoint to use jsonify.
>
>
> Diffs
> -----
>
> src/master/http.cpp 893e0651b89de4df1813f8f4f365eab80a7b3bc2
>
> Diff: https://reviews.apache.org/r/43823/diff/
>
>
> Testing
> -------
>
> make check. Also verified that this endpoint is covered by the unit tests.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43823: Updated `/tasks` master endpoint to use
jsonify.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43823/
-----------------------------------------------------------
(Updated March 11, 2016, 10:10 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Address reviews.
Repository: mesos
Description
-------
Updated `/tasks` master endpoint to use jsonify.
Diffs (updated)
-----
src/master/http.cpp 893e0651b89de4df1813f8f4f365eab80a7b3bc2
Diff: https://reviews.apache.org/r/43823/diff/
Testing
-------
make check. Also verified that this endpoint is covered by the unit tests.
Thanks,
Neil Conway
Re: Review Request 43823: Updated `/tasks` master endpoint to use
jsonify.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43823/#review122956
-----------------------------------------------------------
Fix it, then Ship it!
src/master/http.cpp (line 1849)
<https://reviews.apache.org/r/43823/#comment185051>
`s/taskWriter/tasksWriter/`?
- Michael Park
On Feb. 29, 2016, 6:55 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43823/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 6:55 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `/tasks` master endpoint to use jsonify.
>
>
> Diffs
> -----
>
> src/master/http.cpp d6e1f22620dfc4271244a2983195cffc36da6e8e
>
> Diff: https://reviews.apache.org/r/43823/diff/
>
>
> Testing
> -------
>
> make check. Also verified that this endpoint is covered by the unit tests.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43823: Updated `/tasks` master endpoint to use
jsonify.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43823/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 6:55 a.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase.
Repository: mesos
Description
-------
Updated `/tasks` master endpoint to use jsonify.
Diffs (updated)
-----
src/master/http.cpp d6e1f22620dfc4271244a2983195cffc36da6e8e
Diff: https://reviews.apache.org/r/43823/diff/
Testing
-------
make check. Also verified that this endpoint is covered by the unit tests.
Thanks,
Neil Conway
Re: Review Request 43823: Updated `/tasks` master endpoint to use
jsonify.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43823/
-----------------------------------------------------------
(Updated Feb. 28, 2016, 12:15 a.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase.
Repository: mesos
Description
-------
Updated `/tasks` master endpoint to use jsonify.
Diffs (updated)
-----
src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829
Diff: https://reviews.apache.org/r/43823/diff/
Testing
-------
make check. Also verified that this endpoint is covered by the unit tests.
Thanks,
Neil Conway
Re: Review Request 43823: Updated `/tasks` master endpoint to use
jsonify.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43823/
-----------------------------------------------------------
(Updated Feb. 23, 2016, 10:29 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase.
Repository: mesos
Description
-------
Updated `/tasks` master endpoint to use jsonify.
Diffs (updated)
-----
src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b
Diff: https://reviews.apache.org/r/43823/diff/
Testing
-------
make check. Also verified that this endpoint is covered by the unit tests.
Thanks,
Neil Conway