You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/12/09 09:23:36 UTC

[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #3692: #3256 Provider Scaling out Interface-Add all apis

KomachiSion commented on a change in pull request #3692: #3256 Provider Scaling out Interface-Add all apis
URL: https://github.com/apache/incubator-shardingsphere/pull/3692#discussion_r355333216
 
 

 ##########
 File path: sharding-scaling/sharding-scaling-bootstrap/src/main/java/org/apache/shardingsphere/shardingscaling/Bootstrap.java
 ##########
 @@ -49,72 +41,36 @@
 @Slf4j
 public class Bootstrap {
 
+    private static final int PORT = Integer.parseInt(System.getProperty("port", "8080"));
+
 
 Review comment:
   Moving port to configFile maybe better. You can refer `Bootstrap in sharding-proxy`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services