You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "garydgregory (via GitHub)" <gi...@apache.org> on 2023/09/15 12:48:25 UTC

[GitHub] [commons-text] garydgregory commented on pull request #458: TEXT-231: WordUtils.wrap react to pre-existing "newline string"

garydgregory commented on PR #458:
URL: https://github.com/apache/commons-text/pull/458#issuecomment-1721225252

   -1 as is:
   - This PR will break the build: Run `mvn` to run the default Maven goal which in turn runs all build checks
   - Don't rewrite existing tests: It makes it harder to review the PR and adds the possibility of changing test/feature coverage
   - Don't clutter the tests with @DisplayName, use Javadoc if a test needs explanations, this provides better formatting.
   - In general, keep changes to a minimum to easy the reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org