[jira] [Commented] (TINKERPOP-1165) Tooling Support: Compile with -parameters

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152704#comment-15152704 ] 

ASF GitHub Bot commented on TINKERPOP-1165:
-------------------------------------------

GitHub user rjbriody opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/231

    TINKERPOP-1165:Tooling Support: Compile with -parameters

    https://issues.apache.org/jira/browse/TINKERPOP-1165
    
    Add -parameters to maven compile args.
    
    This can be manually verified w/ something like this
    ```
    System.out.println(GraphTraversal.class.getDeclaredMethods()[0].getParameters()[0].getName());
    ```
    
    Used to print "arg0". Should now print "column".

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rjbriody/incubator-tinkerpop TINKERPOP-1165

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #231
    
----
commit 79be3f85e0732fa819fa0bea8ff4c5597f925f0e
Author: rjbriody <bo...@datastax.com>
Date:   2016-02-18T17:40:57Z

    Add -parameters to compile args.

----


> Tooling Support:  Compile with -parameters
> ------------------------------------------
>
>                 Key: TINKERPOP-1165
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1165
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: build-release
>    Affects Versions: 3.1.1-incubating
>            Reporter: Zachary Kurey
>
> For tools that provide content assist of parameter names for methods, it would be good to have parameter names retained within the compiled class files.  There may be a good reason I can't think of not to enable this, but enabling it is as simple as adding {{-parameters}} to the maven compile plugin configuration:
> {code}
>             <plugin>
>                     <groupId>org.apache.maven.plugins</groupId>
>                     <artifactId>maven-compiler-plugin</artifactId>
>                     <version>3.1</version>
>                     <configuration>
>                         <source>1.8</source>
>                         <target>1.8</target>
>                         <compilerArgs>
>                                 <arg>-parameters</arg> 
>                         </compilerArgs>
>                     </configuration>
>                 </plugin>
> {code}
> In the root pom.xml of the project.  
> Of course there are other ways to go about this processing the sources or javadoc(provided every public method is very well documented), but this is the simplest way to expose the meaningful param names to tooling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)