[GitHub] [iceberg] rdblue commented on a change in pull request #3989: Python: MapType missing required methods and visit() not supporting MapType

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3989:
URL: https://github.com/apache/iceberg/pull/3989#discussion_r793973916



##########
File path: python_legacy/iceberg/api/types/types.py
##########
@@ -696,6 +696,12 @@ def key_id(self):
     def value_id(self):
         return self.value_field.field_id
 
+    def asMapType(self):

Review comment:
       It looks like these are being converted to snake_case instead. Should this be converted as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org