You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/06/07 09:30:42 UTC
Review Request 48329: LENS-1172: TestQueryServiceDuplicate failing in
tearDown
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48329/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1172
https://issues.apache.org/jira/browse/LENS-1172
Repository: lens
Description
-------
The test class has an AfterMethod tearDown method, which drops a table and closes a session. But the session and the table don't get created until the test method of this class is run. Furthermore, this test depends on other test groups. So if any of the tests of those groups fail, the tests of this class won't be run. But the tearDown will still be run since setUp was run too.
Proposed fix is to drop the table and close the session in the test method itself.
Diffs
-----
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
Diff: https://reviews.apache.org/r/48329/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 48329: LENS-1172: TestQueryServiceDuplicate
failing in tearDown
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48329/#review136585
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On June 7, 2016, 9:41 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48329/
> -----------------------------------------------------------
>
> (Updated June 7, 2016, 9:41 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1172
> https://issues.apache.org/jira/browse/LENS-1172
>
>
> Repository: lens
>
>
> Description
> -------
>
> The test class has an AfterMethod tearDown method, which drops a table and closes a session. But the session and the table don't get created until the test method of this class is run. Furthermore, this test depends on other test groups. So if any of the tests of those groups fail, the tests of this class won't be run. But the tearDown will still be run since setUp was run too.
>
> Proposed fix is to drop the table and close the session in the test method itself.
>
>
> Diffs
> -----
>
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
>
> Diff: https://reviews.apache.org/r/48329/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 48329: LENS-1172: TestQueryServiceDuplicate
failing in tearDown
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48329/
-----------------------------------------------------------
(Updated June 8, 2016, 2:03 p.m.)
Review request for lens.
Bugs: LENS-1172
https://issues.apache.org/jira/browse/LENS-1172
Repository: lens
Description
-------
The test class has an AfterMethod tearDown method, which drops a table and closes a session. But the session and the table don't get created until the test method of this class is run. Furthermore, this test depends on other test groups. So if any of the tests of those groups fail, the tests of this class won't be run. But the tearDown will still be run since setUp was run too.
Proposed fix is to drop the table and close the session in the test method itself.
Diffs (updated)
-----
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
Diff: https://reviews.apache.org/r/48329/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 48329: LENS-1172: TestQueryServiceDuplicate
failing in tearDown
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48329/
-----------------------------------------------------------
(Updated June 8, 2016, 1:49 p.m.)
Review request for lens.
Bugs: LENS-1172
https://issues.apache.org/jira/browse/LENS-1172
Repository: lens
Description
-------
The test class has an AfterMethod tearDown method, which drops a table and closes a session. But the session and the table don't get created until the test method of this class is run. Furthermore, this test depends on other test groups. So if any of the tests of those groups fail, the tests of this class won't be run. But the tearDown will still be run since setUp was run too.
Proposed fix is to drop the table and close the session in the test method itself.
Diffs (updated)
-----
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
Diff: https://reviews.apache.org/r/48329/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 48329: LENS-1172: TestQueryServiceDuplicate
failing in tearDown
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48329/
-----------------------------------------------------------
(Updated June 7, 2016, 3:11 p.m.)
Review request for lens.
Bugs: LENS-1172
https://issues.apache.org/jira/browse/LENS-1172
Repository: lens
Description
-------
The test class has an AfterMethod tearDown method, which drops a table and closes a session. But the session and the table don't get created until the test method of this class is run. Furthermore, this test depends on other test groups. So if any of the tests of those groups fail, the tests of this class won't be run. But the tearDown will still be run since setUp was run too.
Proposed fix is to drop the table and close the session in the test method itself.
Diffs (updated)
-----
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java 082840300e983b90bc2c43fb8555bf1860fe6bbc
Diff: https://reviews.apache.org/r/48329/diff/
Testing
-------
Thanks,
Rajat Khandelwal