You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by keypointt <gi...@git.apache.org> on 2016/07/15 21:54:12 UTC

[GitHub] spark pull request #14226: [SPARK-16580][CORE] class Accumulator in package ...

GitHub user keypointt opened a pull request:

    https://github.com/apache/spark/pull/14226

    [SPARK-16580][CORE] class Accumulator in package spark is deprecated: use AccumulatorV2

    https://issues.apache.org/jira/browse/SPARK-16580#
    
    ## What changes were proposed in this pull request?
    
    When I was working on the R wrapper, I found the compile warn.
    ```
    > project mllib
    > console
    [warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala:78: class Accumulator in package spark is deprecated: use AccumulatorV2
    [warn]     accumulator: Accumulator[JList[Array[Byte]]])
    [warn]
    [warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala:78: class Accumulator in package spark is deprecated: use AccumulatorV2
    [warn]     accumulator: Accumulator[JList[Array[Byte]]])
    [warn]
    [warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala:78: class Accumulator in package spark is deprecated: use AccumulatorV2
    [warn]     accumulator: Accumulator[JList[Array[Byte]]])
    [warn]
    [warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala:71: class Accumulator in package spark is deprecated: use AccumulatorV2
    [warn] private[spark] case class PythonFunction(
    [warn]
    [warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala:78: class Accumulator in package spark is deprecated: use AccumulatorV2
    [warn]     accumulator: Accumulator[JList[Array[Byte]]])
    [warn]
    [warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala:873: trait AccumulatorParam in package spark is deprecated: use AccumulatorV2
    [warn]   extends AccumulatorParam[JList[Array[Byte]]] {
    [warn]
    [warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala:459: trait AccumulableParam in package spark is deprecated: use AccumulatorV2
    [warn]     param: org.apache.spark.AccumulableParam[R, T]) extends AccumulatorV2[T, R] {
    [warn]
    [warn] /Users/renxin/workspace/spark/core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala:459: trait AccumulableParam in package spark is deprecated: use AccumulatorV2
    [warn]     param: org.apache.spark.AccumulableParam[R, T]) extends AccumulatorV2[T, R] {
    [warn]
    ```
    
    Using `AccumulatorV2` and warnings on "PythonRDD.scala:78" and "PythonRDD.scala:71" disappeared. 
    
    I didn't change `AccumulableParam` or `AccumulatorParam`, since they are being used in `class LegacyAccumulatorWrapper` of `AccumulatorV2`.
    
    ## How was this patch tested?
    
    Tested manually on my laptop.
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/keypointt/spark SPARK-16580

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14226
    
----
commit 84db7265250eef147c8d51e539ace9f9dfc35a19
Author: Xin Ren <ia...@126.com>
Date:   2016-07-15T20:50:43Z

    compile ok

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14226: [SPARK-16580][CORE] class Accumulator in package spark i...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/14226
  
    @keypointt what do you think about following up on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14226: [SPARK-16580][CORE] class Accumulator in package spark i...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14226
  
    **[Test build #62389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62389/consoleFull)** for PR 14226 at commit [`84db726`](https://github.com/apache/spark/commit/84db7265250eef147c8d51e539ace9f9dfc35a19).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14226: [SPARK-16580][CORE] class Accumulator in package spark i...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14226
  
    **[Test build #63192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63192/consoleFull)** for PR 14226 at commit [`fe83dd9`](https://github.com/apache/spark/commit/fe83dd91f1f54d7016946ea31f1b1107553a37e3).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14226: [SPARK-16580][CORE] class Accumulator in package spark i...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14226
  
    **[Test build #62389 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62389/consoleFull)** for PR 14226 at commit [`84db726`](https://github.com/apache/spark/commit/84db7265250eef147c8d51e539ace9f9dfc35a19).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14226: [SPARK-16580][CORE] class Accumulator in package spark i...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14226
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63192/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14226: [SPARK-16580][CORE] class Accumulator in package spark i...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14226
  
    **[Test build #63192 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63192/consoleFull)** for PR 14226 at commit [`fe83dd9`](https://github.com/apache/spark/commit/fe83dd91f1f54d7016946ea31f1b1107553a37e3).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14226: [SPARK-16580][CORE] class Accumulator in package spark i...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/14226
  
    Yeah let's close this one as a duplicate


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14226: [SPARK-16580][CORE] class Accumulator in package spark i...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14226
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14226: [SPARK-16580][CORE] class Accumulator in package spark i...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14226
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14226: [SPARK-16580][CORE] class Accumulator in package spark i...

Posted by keypointt <gi...@git.apache.org>.

Github user keypointt commented on the issue:

    https://github.com/apache/spark/pull/14226
  
    sure, closing it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14226: [SPARK-16580][CORE] class Accumulator in package spark i...

Posted by MLnick <gi...@git.apache.org>.

Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/14226
  
    I think #14467 is addressing this, and seems to be further along (it is a little more involved to make it work than what you have here)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org