You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by gonzalad <gi...@git.apache.org> on 2017/06/23 08:48:18 UTC

[GitHub] cxf-fediz pull request #19: Normalize URLs in LogoutService

GitHub user gonzalad opened a pull request:

    https://github.com/apache/cxf-fediz/pull/19

    Normalize URLs in LogoutService

    LogoutService can produce URLs like :
    ```
    http://localhost:9080/oidc/idp/logout/../../secure/logout
       ?wreply=http%3A//localhost%3A9999&client_id=5451ddss
    ```
    when LogoutServer.relativeIdpLogoutUri=../../secure/logout
    
    Some software (i.e. Gatling doesn't handle this kind of
    URLs).
    
    This commit normalizes these kind of URLs

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gonzalad/cxf-fediz url-norm

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf-fediz/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
    
----
commit aa93cd94ffbdba9e1406b48d7aaa022633b81210
Author: gonzalad <ad...@yahoo.fr>
Date:   2017-06-23T07:16:52Z

    Normalize URLs in LogoutService
    
    LogoutService can produce URLs like :
    ```
    http://localhost:9080/oidc/idp/logout/../../secure/logout
       ?wreply=http%3A//localhost%3A9999&client_id=5451ddss
    ```
    when LogoutServer.relativeIdpLogoutUri=../../secure/logout
    
    Some software (i.e. Gatling doesn't handle this kind of
    URLs).
    
    This commit normalizes these kind of URLs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cxf-fediz pull request #19: Normalize URLs in LogoutService

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cxf-fediz/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cxf-fediz issue #19: Normalize URLs in LogoutService

Posted by sberyozkin <gi...@git.apache.org>.
Github user sberyozkin commented on the issue:

    https://github.com/apache/cxf-fediz/pull/19
  
    UriInfo.resolve and UriInfo.relativize are also available as apparently URI.normalize does not always work right, but yeah, I guess in simple cases it should do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---