You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/18 01:25:33 UTC

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #250: feat: ingress v1

tokers commented on a change in pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#discussion_r578060348



##########
File path: cmd/ingress/ingress_test.go
##########
@@ -105,6 +105,9 @@ func TestSignalHandler(t *testing.T) {
 }
 
 func TestNewIngressCommandEffectiveLog(t *testing.T) {
+	// Delay for 2 seconds to avoid conflicting with the
+	// TestSignalHandler case.
+	time.Sleep(2 * time.Second)

Review comment:
       Not the conflicts of port, just like the conflicts about terminal (stdout).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org