You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by er...@apache.org on 2019/03/11 18:03:38 UTC
[lucene-solr] branch master updated: SOLR-13268: Clean up any test
failures resulting from defaulting to async logging. Fix precommit test to
not include the baseDir
This is an automated email from the ASF dual-hosted git repository.
erick pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
The following commit(s) were added to refs/heads/master by this push:
new 3a1603d SOLR-13268: Clean up any test failures resulting from defaulting to async logging. Fix precommit test to not include the baseDir
3a1603d is described below
commit 3a1603dab349fa828217fe1146e73c6a5f1a4fcf
Author: Erick Erickson <Er...@gmail.com>
AuthorDate: Mon Mar 11 11:03:31 2019 -0700
SOLR-13268: Clean up any test failures resulting from defaulting to async logging. Fix precommit test to not include the baseDir
---
lucene/tools/src/groovy/check-source-patterns.groovy | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lucene/tools/src/groovy/check-source-patterns.groovy b/lucene/tools/src/groovy/check-source-patterns.groovy
index e2dfb30..f0007ea 100644
--- a/lucene/tools/src/groovy/check-source-patterns.groovy
+++ b/lucene/tools/src/groovy/check-source-patterns.groovy
@@ -181,7 +181,8 @@ ant.fileScanner{
if (f.name.contains("Test")) {
checkMockitoAssume(f, text);
}
- if (f.path.contains("solr/") && f.name.equals("SolrTestCase.java") == false) {
+
+ if (f.path.substring(baseDirLen).contains("solr/") && f.name.equals("SolrTestCase.java") == false) {
if (extendsLuceneTestCasePattern.matcher(text).find()) {
reportViolation(f, "Solr test cases should extend SolrTestCase rather than LuceneTestCase");
}