You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/06/27 04:45:49 UTC
[kudu-CR] [tests] fix flake in one AdminCliTest's scenario
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10836
Change subject: [tests] fix flake in one AdminCliTest's scenario
......................................................................
[tests] fix flake in one AdminCliTest's scenario
AdminCliTest::TestUnsafeChangeConfigWithMultiplePendingConfigs
had a race condition: leader re-election between calls of
FindTabletLeader() and FindTabletFollowers(), with frequency
about 1/300 if running with dist-test.
The updated code does not contain that race: more then 2K runs
of dist-test passed without a single failure.
In addition to that, this patch contains minor clean-up
related to the RunUnsafeChangeConfig() function.
Change-Id: Iafbaca77d9f0c795bb1787923d50f9fe0a41f334
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 21 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/10836/1
--
To view, visit http://gerrit.cloudera.org:8080/10836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafbaca77d9f0c795bb1787923d50f9fe0a41f334
Gerrit-Change-Number: 10836
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tests] fix flake in one AdminCliTest's scenario
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10836 )
Change subject: [tests] fix flake in one AdminCliTest's scenario
......................................................................
[tests] fix flake in one AdminCliTest's scenario
AdminCliTest::TestUnsafeChangeConfigWithMultiplePendingConfigs
had a race condition: leader re-election between calls of
FindTabletLeader() and FindTabletFollowers(), with frequency
about 1/300 if running with dist-test.
The updated code does not contain that race: more then 2K runs
of dist-test passed without a single failure.
In addition to that, this patch contains minor clean-up
related to the RunUnsafeChangeConfig() function.
Change-Id: Iafbaca77d9f0c795bb1787923d50f9fe0a41f334
Reviewed-on: http://gerrit.cloudera.org:8080/10836
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 21 insertions(+), 22 deletions(-)
Approvals:
Alexey Serbin: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafbaca77d9f0c795bb1787923d50f9fe0a41f334
Gerrit-Change-Number: 10836
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [tests] fix flake in one AdminCliTest's scenario
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10836 )
Change subject: [tests] fix flake in one AdminCliTest's scenario
......................................................................
Patch Set 1: Verified+1
Unrelated flake in RebalanceParamTest.Rebalance/2
--
To view, visit http://gerrit.cloudera.org:8080/10836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafbaca77d9f0c795bb1787923d50f9fe0a41f334
Gerrit-Change-Number: 10836
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 27 Jun 2018 05:53:27 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] fix flake in one AdminCliTest's scenario
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10836 )
Change subject: [tests] fix flake in one AdminCliTest's scenario
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafbaca77d9f0c795bb1787923d50f9fe0a41f334
Gerrit-Change-Number: 10836
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Jun 2018 08:10:52 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] fix flake in one AdminCliTest's scenario
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10836 )
Change subject: [tests] fix flake in one AdminCliTest's scenario
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Iafbaca77d9f0c795bb1787923d50f9fe0a41f334
Gerrit-Change-Number: 10836
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>