You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/12/28 05:34:24 UTC

[kudu-CR] [gflags] use DEFINE validator() macro 

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14955


Change subject: [gflags] use DEFINE_validator() macro
......................................................................

[gflags] use DEFINE_validator() macro

Updated few places to use the DEFINE_validator() macro, replacing
ad-hoc calls to RegisterFlagValidator().

This patch doesn't contain any functional modifications.

Change-Id: Ied1ad630838768600c245dd4952506e2fad6ec3f
---
M src/kudu/consensus/log.cc
M src/kudu/rpc/transfer.cc
M src/kudu/tools/color.cc
M src/kudu/util/process_memory.cc
4 files changed, 6 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/14955/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied1ad630838768600c245dd4952506e2fad6ec3f
Gerrit-Change-Number: 14955
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [gflags] use DEFINE validator() macro

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14955 )

Change subject: [gflags] use DEFINE_validator() macro
......................................................................

[gflags] use DEFINE_validator() macro

Updated few places to use the DEFINE_validator() macro, replacing
ad-hoc calls to RegisterFlagValidator().

This patch doesn't contain any functional modifications.

Change-Id: Ied1ad630838768600c245dd4952506e2fad6ec3f
Reviewed-on: http://gerrit.cloudera.org:8080/14955
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/consensus/log.cc
M src/kudu/rpc/transfer.cc
M src/kudu/tools/color.cc
M src/kudu/util/process_memory.cc
4 files changed, 6 insertions(+), 12 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Bankim Bhavsar: Looks good to me, but someone else must approve
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied1ad630838768600c245dd4952506e2fad6ec3f
Gerrit-Change-Number: 14955
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [gflags] use DEFINE validator() macro

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14955 )

Change subject: [gflags] use DEFINE_validator() macro
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied1ad630838768600c245dd4952506e2fad6ec3f
Gerrit-Change-Number: 14955
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 29 Dec 2019 18:37:09 +0000
Gerrit-HasComments: No

[kudu-CR] [gflags] use DEFINE validator() macro

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14955 )

Change subject: [gflags] use DEFINE_validator() macro
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied1ad630838768600c245dd4952506e2fad6ec3f
Gerrit-Change-Number: 14955
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 28 Dec 2019 15:03:38 +0000
Gerrit-HasComments: No