You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/06/17 23:41:58 UTC
[GitHub] [trafficserver] bneradt opened a new pull request, #8919: AuTest: bind stdout/stderr to traffic.out
bneradt opened a new pull request, #8919:
URL: https://github.com/apache/trafficserver/pull/8919
This updates our AuTest invocation of traffic_server to bind its stdout
and stderr output to traffic.out. Doing this allows the tests to
dynamically interact with the traffic.out content, such as waiting upon
certian debug tag lines. It also serves as a debugging convenience since
all logging output for a Traffic Server process will be in its log dir:
diags.log, error.log, etc., and now traffic.out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8919: AuTest: bind stdout/stderr to traffic.out
Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8919:
URL: https://github.com/apache/trafficserver/pull/8919#issuecomment-1163571475
> I'm not sure if it's an issue. I noticed that in file: tests/gold_tests/pluginTest/stek_share/stek_share.test.py
>
> Lines 225 to 229 begin with **ts1**.Disk.traffic_out.Content but maybe should begin with: **ts1**.Disk.traffic_out.Content (...) **ts2**.Disk.traffic_out.Content (...) ... **ts5**.Disk.traffic_out.Content (...)
Good catch, @marcin-wadolkowski . Fixing in #8921.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #8919: AuTest: bind stdout/stderr to traffic.out
Posted by GitBox <gi...@apache.org>.
bneradt merged PR #8919:
URL: https://github.com/apache/trafficserver/pull/8919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a diff in pull request #8919: AuTest: bind stdout/stderr to traffic.out
Posted by GitBox <gi...@apache.org>.
bneradt commented on code in PR #8919:
URL: https://github.com/apache/trafficserver/pull/8919#discussion_r901005242
##########
tests/gold_tests/pluginTest/lua/lua_states_stats.test.py:
##########
@@ -28,12 +28,7 @@
# Define default ATS
server = Test.MakeOriginServer("server")
-# It is necessary to redirect stderr to a file so it will be available for examination by a test run.
-ts = Test.MakeATSProcess(
- "ts", command="traffic_manager 2> " + Test.RunDirectory + "/ts.stderr.txt", select_ports=True
-)
Review Comment:
This is an example of something no longer necessary if we bind stdout and stderr to traffic.out. Instead we can simply interact with traffic.out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8919: AuTest: bind stdout/stderr to traffic.out
Posted by GitBox <gi...@apache.org>.
zwoop commented on PR #8919:
URL: https://github.com/apache/trafficserver/pull/8919#issuecomment-1319295447
We need this for other PRs to CP.
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] marcin-wadolkowski commented on pull request #8919: AuTest: bind stdout/stderr to traffic.out
Posted by GitBox <gi...@apache.org>.
marcin-wadolkowski commented on PR #8919:
URL: https://github.com/apache/trafficserver/pull/8919#issuecomment-1162897890
I'm not sure if it's an issue. I noticed that in file:
tests/gold_tests/pluginTest/stek_share/stek_share.test.py
Lines 225 to 229 begin with **ts1**.Disk.traffic_out.Content but maybe should begin with:
**ts1**.Disk.traffic_out.Content (...)
**ts2**.Disk.traffic_out.Content (...)
...
**ts5**.Disk.traffic_out.Content (...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a diff in pull request #8919: AuTest: bind stdout/stderr to traffic.out
Posted by GitBox <gi...@apache.org>.
bneradt commented on code in PR #8919:
URL: https://github.com/apache/trafficserver/pull/8919#discussion_r901005242
##########
tests/gold_tests/pluginTest/lua/lua_states_stats.test.py:
##########
@@ -28,12 +28,7 @@
# Define default ATS
server = Test.MakeOriginServer("server")
-# It is necessary to redirect stderr to a file so it will be available for examination by a test run.
-ts = Test.MakeATSProcess(
- "ts", command="traffic_manager 2> " + Test.RunDirectory + "/ts.stderr.txt", select_ports=True
-)
Review Comment:
This is an example of something no longer necessary with this patch since we bind stdout and stderr to traffic.out. Instead we can simply interact with traffic.out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org