You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/13 11:47:13 UTC

[GitHub] [arrow] zhztheplayer edited a comment on pull request #10652: ARROW-13257: [Java][Dataset] Allow passing empty columns for projection

zhztheplayer edited a comment on pull request #10652:
URL: https://github.com/apache/arrow/pull/10652#issuecomment-918110918


   @emkornfield @liyafan82 @kiszk Could you please help me review this PR? Thanks a lot.
   
   This is basically a fix for Dataset Java API to make it be able to scan within empty projector. The test cases is here https://github.com/apache/arrow/pull/10652/files#diff-8b46992e017975d0c5c66fc6d8c66a3e4b069e0caa0fad2cad52c7fb298f31b4R131-R174
   
   Previous in Java we had both null and empty projector indicating for "no projection" (all columns will be scanned out). This is to keep up with newest C++ code that empty projection means "scan for zero columns", only null projection is for "no projection"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org