You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2015/04/06 05:20:12 UTC

[jira] [Commented] (ACCUMULO-2325) Avoid repeated checking in addViolation in NumericValueConstraint and AlphaNumKeyContraint

    [ https://issues.apache.org/jira/browse/ACCUMULO-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14480882#comment-14480882 ] 

Josh Elser commented on ACCUMULO-2325:
--------------------------------------

I'll try to take a look at this. Sorry for it sitting for so long.

> Avoid repeated checking in addViolation in NumericValueConstraint and AlphaNumKeyContraint
> ------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-2325
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2325
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Vikram Srivastava
>            Assignee: Vikram Srivastava
>            Priority: Minor
>             Fix For: 1.7.0
>
>         Attachments: ACCUMULO-2325.v1.patch.txt
>
>
> addViolation is very verbose and does check for null on every violation. Instead we can initialize violations as non-null just return null from check if the list is empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)