You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/04/30 20:41:12 UTC
[GitHub] [geode] kirklund opened a new pull request #5033: DRAFT: GEODE-8040: Make BootstrappingFunction unit testable
kirklund opened a new pull request #5033:
URL: https://github.com/apache/geode/pull/5033
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund closed pull request #5033: DRAFT: GEODE-8040: Make BootstrappingFunction unit testable
Posted by GitBox <gi...@apache.org>.
kirklund closed pull request #5033:
URL: https://github.com/apache/geode/pull/5033
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund edited a comment on pull request #5033: DRAFT: GEODE-8040: Make BootstrappingFunction unit testable
Posted by GitBox <gi...@apache.org>.
kirklund edited a comment on pull request #5033:
URL: https://github.com/apache/geode/pull/5033#issuecomment-624869797
@jdeppe-pivotal do you have any ideas why any changes to BootstrappingFunction causes the Tomcat session tests in UpgradeTest to fail? I only made changes to BootstrappingFunction to enable it to be well unit tested, but after a week I still can't get it to pass. I'm reluctant to throw away the changes but I'm out of time. I moved BootstrappingFunctionTest to BootstrappingFunctionIntegrationTest because it creates a full Cache despite the use of Mockito. The when/thenReturn stubbing for the BootstrappingFunction spy is incorrect -- the test executes the real code and THEN returns the mockCache -- but the real code creates a real Cache that then isn't used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund commented on pull request #5033: DRAFT: GEODE-8040: Make BootstrappingFunction unit testable
Posted by GitBox <gi...@apache.org>.
kirklund commented on pull request #5033:
URL: https://github.com/apache/geode/pull/5033#issuecomment-624869797
@jdeppe-pivotal do you have any ideas why any changes to BootstrappingFunction causes the Tomcat session tests in UpgradeTest to fail?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund edited a comment on pull request #5033: DRAFT: GEODE-8040: Make BootstrappingFunction unit testable
Posted by GitBox <gi...@apache.org>.
kirklund edited a comment on pull request #5033:
URL: https://github.com/apache/geode/pull/5033#issuecomment-624869797
@jdeppe-pivotal do you have any ideas why any changes to BootstrappingFunction causes the Tomcat session tests in UpgradeTest to fail? I only made changes to BootstrappingFunction to enable it to be well unit tested, but after a week I still can't get it to pass. I'm reluctant to throw away the changes but I can't get it to pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org