[GitHub] dubee commented on issue #3286: Treat action code as attachments for all runtimes and cache attachments

[GitBox <gi...@apache.org>]

dubee commented on issue #3286: Treat action code as attachments for all runtimes and cache attachments
URL: https://github.com/apache/incubator-openwhisk/pull/3286#issuecomment-385749385
 
 
   @rabbah, @markusthoemmes, a cache concurrency test fails on this one. I have figured out the failure is due the need of two DB writes for saving attachments. Where the first write is for the DB document and the second write is for the DB document attachment. 
   
   When only caching Java actions as done in https://github.com/apache/incubator-openwhisk/pull/2855 and implementing the same concurrency test for Java actions, the test will fail as well.
   ```
   
   Failure output shown here. The test fails because `update` does two writes as stated above, so a concurrent `get` request can fail as `update` does not finish as quickly for attachments.
   ```
   whisk.core.database.test.CacheConcurrencyTests > the cache should support concurrent CRUD without bogus residual cache entries, iter 1 FAILED
       org.scalatest.exceptions.TestFailedException: update+get: failed for testy4 404 was not equal to 200
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services