[GitHub] [tinkerpop] FlorianHockmann commented on a diff in pull request #1788: Dev Environments: Dockerize Testing for JavaScript and .NET & Updates for Go

[GitBox <gi...@apache.org>]

FlorianHockmann commented on code in PR #1788:
URL: https://github.com/apache/tinkerpop/pull/1788#discussion_r964499591


##########
gremlin-dotnet/test/pom.xml:
##########
@@ -115,16 +116,29 @@ limitations under the License.
                                 </goals>
                                 <configuration>
                                     <skip>${skipTests}</skip>
-                                    <environmentVariables>
-                                        <GREMLIN_SERVER>${project.version}</GREMLIN_SERVER>
-                                        <HOME>${user.home}</HOME>
-                                    </environmentVariables>
+                                    <!-- don't need to set env variables for container tear down -->
                                     <executable>docker-compose</executable>
                                     <arguments>
                                         <argument>down</argument>
                                     </arguments>
                                 </configuration>
                             </execution>
+                            <execution>
+                                <id>remove-dangling-images</id>
+                                <phase>integration-test</phase>
+                                <goals>
+                                    <goal>exec</goal>
+                                </goals>
+                                <configuration>
+                                    <skip>${skipTests}</skip>
+                                    <executable>docker</executable>
+                                    <arguments>
+                                        <argument>image</argument>
+                                        <argument>prune</argument>

Review Comment:
   Won't this remove all images on the machine this is executed on, including images completely unrelated to our build? I'm not sure if we really want that. We should only clean up images that we've created ourselves.
   How about just removing the containers completely with [`docker-compose rm -f`](https://docs.docker.com/engine/reference/commandline/compose_rm/)? I think it's OK to keep the images (not the containers) on the machine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org