You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "C0urante (via GitHub)" <gi...@apache.org> on 2023/05/15 22:57:38 UTC
[GitHub] [kafka] C0urante opened a new pull request, #13723: KAFKA-14980: Fix MirrorSourceConnector source consumer configuration
C0urante opened a new pull request, #13723:
URL: https://github.com/apache/kafka/pull/13723
[Jira](https://issues.apache.org/jira/browse/KAFKA-14980)
Fixes a typo introduced in https://github.com/apache/kafka/pull/12366 that breaks how the consumer for the source cluster is configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jlprat commented on a diff in pull request #13723: KAFKA-14980: Fix MirrorSourceConnector source consumer configuration
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on code in PR #13723:
URL: https://github.com/apache/kafka/pull/13723#discussion_r1196222089
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorConfigTest.java:
##########
@@ -43,7 +43,8 @@ protected TestMirrorConnectorConfig(Map<String, String> props) {
@Test
public void testSourceConsumerConfig() {
Map<String, String> connectorProps = makeProps(
- MirrorConnectorConfig.CONSUMER_CLIENT_PREFIX + "max.poll.interval.ms", "120000"
+ MirrorConnectorConfig.CONSUMER_CLIENT_PREFIX + "max.poll.interval.ms", "120000",
+ MirrorConnectorConfig.SOURCE_CLUSTER_PREFIX + "bootstrap.servers", "localhost:2345"
Review Comment:
Nice to add a test to avoid the having the same mistake again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #13723: KAFKA-14980: Fix MirrorSourceConnector source consumer configuration
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #13723:
URL: https://github.com/apache/kafka/pull/13723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #13723: KAFKA-14980: Fix MirrorSourceConnector source consumer configuration
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13723:
URL: https://github.com/apache/kafka/pull/13723#issuecomment-1554625003
Backported to 3.5 too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org