You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/02/13 11:50:44 UTC
Review Request 56597: Externalize the logic for making navigation bar
interactive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56597/
-----------------------------------------------------------
Review request for Ambari and Jaimin Jetly.
Bugs: AMBARI-19983
https://issues.apache.org/jira/browse/AMBARI-19983
Repository: ambari
Description
-------
Externalize the logic for making navigation bar interactive
Diffs
-----
ambari-web/app/assets/data/clusters/info.json PRE-CREATION
ambari-web/app/styles/side_navigation.less 48b8699
ambari-web/app/styles/theme/bootstrap-ambari.css adbddcd
ambari-web/app/templates/application.hbs f18d314
ambari-web/app/templates/main/side-menu-item.hbs 27739c8
ambari-web/app/views/application.js f79aad9
ambari-web/app/views/main/menu.js d82d56a
ambari-web/brunch-config.js d646fdc
ambari-web/vendor/scripts/theme/bootstrap-ambari.js PRE-CREATION
Diff: https://reviews.apache.org/r/56597/diff/
Testing
-------
20325 passing (22s)
153 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 56597: Externalize the logic for making navigation
bar interactive
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56597/#review165592
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Feb. 13, 2017, 11:50 a.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56597/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 11:50 a.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: AMBARI-19983
> https://issues.apache.org/jira/browse/AMBARI-19983
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Externalize the logic for making navigation bar interactive
>
>
> Diffs
> -----
>
> ambari-web/app/assets/data/clusters/info.json PRE-CREATION
> ambari-web/app/styles/side_navigation.less 48b8699
> ambari-web/app/styles/theme/bootstrap-ambari.css adbddcd
> ambari-web/app/templates/application.hbs f18d314
> ambari-web/app/templates/main/side-menu-item.hbs 27739c8
> ambari-web/app/views/application.js f79aad9
> ambari-web/app/views/main/menu.js d82d56a
> ambari-web/brunch-config.js d646fdc
> ambari-web/vendor/scripts/theme/bootstrap-ambari.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/56597/diff/
>
>
> Testing
> -------
>
> 20325 passing (22s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>