You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2020/12/13 11:24:29 UTC
[GitHub] [struts-site] yasserzamani commented on a change in pull request #154: Possible site tag documentation updates for WW-5093.
yasserzamani commented on a change in pull request #154:
URL: https://github.com/apache/struts-site/pull/154#discussion_r541903584
##########
File path: source/core-developers/accessing-application-session-request-objects.md
##########
@@ -50,16 +50,24 @@ is an alternative way to access the request and response objects, with the same
## Accessing from the view (JSP, FreeMarker, etc.)
Request and session attributes are accessed via OGNL using the `#session` and `#request` stack values.
+Page attributes are accessed via OGNL using the `#attr` stack value, and Application attributes via
+the `#application` stack value.
The `#attr` stack value will search the `javax.servlet.jsp.PageContext` for the specified key. If the `PageContext`
-doean't exist, it will search the request, session, and application scopes, in that order.
+doesn't exist, it will search the request, session, and application scopes, in that order.
-**Accessing the Session or Request from a JSP**
+**Accessing attributes in the Application, Session, Request, or Page scope from a JSP**
```jsp
Review comment:
xml is better I think to highlight.
##########
File path: source/core-developers/accessing-application-session-request-objects.md
##########
@@ -50,16 +50,24 @@ is an alternative way to access the request and response objects, with the same
## Accessing from the view (JSP, FreeMarker, etc.)
Request and session attributes are accessed via OGNL using the `#session` and `#request` stack values.
+Page attributes are accessed via OGNL using the `#attr` stack value, and Application attributes via
+the `#application` stack value.
The `#attr` stack value will search the `javax.servlet.jsp.PageContext` for the specified key. If the `PageContext`
-doean't exist, it will search the request, session, and application scopes, in that order.
+doesn't exist, it will search the request, session, and application scopes, in that order.
-**Accessing the Session or Request from a JSP**
+**Accessing attributes in the Application, Session, Request, or Page scope from a JSP**
```jsp
+Retrieve the attribute (property), with key myId, from the specified scope:
Review comment:
Nice to use xml comment here i.e. `<!-- .... -->`
##########
File path: source/tag-developers/set-tag.md
##########
@@ -25,9 +25,10 @@ The scopes available are as follows:
- `session` - the value will be set in session scope according to servlet spec. using the name as key
- `request` - the value will be set in request scope according to servlet spec. using the name as key
- `page` - the value will be set in page scope according to servlet spec. using the name as key
-- `action` - the value will be set in the request scope and Struts' action context using the name as key
+- `action` - the value will be set in the page scope and Struts' action context using the name as key
Review comment:
I think action would be request (thread) scope theoretically?
##########
File path: source/core-developers/accessing-application-session-request-objects.md
##########
@@ -50,16 +50,24 @@ is an alternative way to access the request and response objects, with the same
## Accessing from the view (JSP, FreeMarker, etc.)
Request and session attributes are accessed via OGNL using the `#session` and `#request` stack values.
+Page attributes are accessed via OGNL using the `#attr` stack value, and Application attributes via
+the `#application` stack value.
The `#attr` stack value will search the `javax.servlet.jsp.PageContext` for the specified key. If the `PageContext`
-doean't exist, it will search the request, session, and application scopes, in that order.
+doesn't exist, it will search the request, session, and application scopes, in that order.
-**Accessing the Session or Request from a JSP**
+**Accessing attributes in the Application, Session, Request, or Page scope from a JSP**
```jsp
+Retrieve the attribute (property), with key myId, from the specified scope:
+
+<s:property value="#application.myId" />
+
<s:property value="#session.myId" />
<s:property value="#request.myId" />
<s:property value="#attr.myId" />
+
+Reminder: attr is for Page scope attributes first, but will search the remaining scopes, in order, seeking a match.
Review comment:
(same here)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org