You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by blrunner <gi...@git.apache.org> on 2014/10/24 03:04:04 UTC
[GitHub] tajo pull request: TAJO-1119: JDBC driver should support TIMESTAMP...
GitHub user blrunner opened a pull request:
https://github.com/apache/tajo/pull/208
TAJO-1119: JDBC driver should support TIMESTAMP type.
TAJO-1119: JDBC driver should support TIMESTAMP type.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blrunner/tajo TAJO-1119
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #208
----
commit 7831212dbc11953976450f0569045bd11b27ead2
Author: Jaehwa Jung <bl...@apache.org>
Date: 2014-10-24T01:02:22Z
TAJO-1119: JDBC driver should support TIMESTAMP type.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1119: JDBC driver should support TIMESTAMP...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/208#issuecomment-63257624
TravisCI causes the following error. Could you check it? or could you submit the patch to jira and trigger the jenkins unit test?
```
Results :
Failed tests:
TestJoinQuery.testOuterJoinAndCaseWhen1:314->QueryTestCaseBase.executeDDL:544->QueryTestCaseBase.executeDDL:572 Table [table1] creation is failed.
TestJoinQuery.testOuterJoinAndCaseWhen1:314->QueryTestCaseBase.executeDDL:544->QueryTestCaseBase.executeDDL:572 Table [table1] creation is failed.
TestJoinQuery.testOuterJoinAndCaseWhen1:314->QueryTestCaseBase.executeDDL:544->QueryTestCaseBase.executeDDL:572 Table [table1] creation is failed.
TestJoinQuery.testOuterJoinAndCaseWhen1:314->QueryTestCaseBase.executeDDL:544->QueryTestCaseBase.executeDDL:572 Table [table1] creation is failed.
TestSortQuery.testSortWithDate:134->QueryTestCaseBase.executeDDL:544->QueryTestCaseBase.executeDDL:572 Table [table1] creation is failed.
Tests in error:
TestGroupByQuery.testGroupByWithNullData5:586->QueryTestCaseBase.executeString:293 » Service
TestGroupByQuery.testGroupByWithNullData6:598->QueryTestCaseBase.executeString:293 » Service
TestGroupByQuery.testGroupByWithNullData7:610->QueryTestCaseBase.executeString:293 » Service
TestGroupByQuery.testGroupByWithNullData8:622->QueryTestCaseBase.executeString:293 » Service
TestGroupByQuery.testGroupByWithNullData9:634->QueryTestCaseBase.executeString:293 » Service
TestGroupByQuery.testGroupByWithNullData5:586->QueryTestCaseBase.executeString:293 » Service
TestGroupByQuery.testGroupByWithNullData6:598->QueryTestCaseBase.executeString:293 » Service
TestGroupByQuery.testGroupByWithNullData7:610->QueryTestCaseBase.executeString:293 » Service
TestGroupByQuery.testGroupByWithNullData8:622->QueryTestCaseBase.executeString:293 » Service
TestGroupByQuery.testGroupByWithNullData9:634->QueryTestCaseBase.executeString:293 » Service
TestJoinBroadcast.testLeftOuterJoinLeftSideSmallTable:590 » Service java.sql.S...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1119: JDBC driver should support TIMESTAMP...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/208#issuecomment-64325958
+1
Ship it. The patch looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1119: JDBC driver should support TIMESTAMP...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/208#issuecomment-63444349
Hi @hyunsik
I fixed a bug. The Travis CI build will build successfully tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1119: JDBC driver should support TIMESTAMP...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/208#issuecomment-63255740
Hi @hyunsik
I added a unit test case to verify ResultSet.
Could you check the patch again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1119: JDBC driver should support TIMESTAMP...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/208#issuecomment-64795740
Thanks @hyunsik.
I've just committed it to master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1119: JDBC driver should support TIMESTAMP...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/208#issuecomment-62633063
Hi @blrunner,
I think this fix should be included in 0.9.1. How do you think about that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1119: JDBC driver should support TIMESTAMP...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/208#issuecomment-60454791
The patch looks good to me.
But, this patch seems to omit the test to retrieve values. Could you add more unit tests to get timestamp values from JDBC ResultSet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1119: JDBC driver should support TIMESTAMP...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/208#issuecomment-63444869
Thank you for your contribution. I'll review the patch soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1119: JDBC driver should support TIMESTAMP...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner closed the pull request at:
https://github.com/apache/tajo/pull/208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1119: JDBC driver should support TIMESTAMP...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/208#issuecomment-62831834
Hi @hyunsik
NP... I'll add more unit test cases by tomorrow night. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---