You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/14 22:59:57 UTC

[GitHub] [spark] gfosco opened a new pull request #28533: Update ChiSqSelectorExample to show import

gfosco opened a new pull request #28533:
URL: https://github.com/apache/spark/pull/28533


   I found this via the mailing list, a user had submitted this change to the spark-website repo and was told to submit it here.  Six times that happened.  So here is the change, just moving the import into the example block.
   
   ref: http://apache-spark-developers-list.1001551.n3.nabble.com/Block-a-user-from-spark-website-who-repeatedly-open-the-invalid-same-PR-td28759.html
   
   ### What changes were proposed in this pull request?
   Moving 1 line into an example block.
   
   ### Why are the changes needed?
   To make a website example clearer.
   
   ### Does this PR introduce _any_ user-facing change?
   No


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28533: Update ChiSqSelectorExample to show import

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28533:
URL: https://github.com/apache/spark/pull/28533#issuecomment-628930929


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gfosco closed pull request #28533: Update ChiSqSelectorExample to show import

Posted by GitBox <gi...@apache.org>.
gfosco closed pull request #28533:
URL: https://github.com/apache/spark/pull/28533


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28533: Update ChiSqSelectorExample to show import

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28533:
URL: https://github.com/apache/spark/pull/28533#issuecomment-628930929


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gfosco commented on a change in pull request #28533: Update ChiSqSelectorExample to show import

Posted by GitBox <gi...@apache.org>.
gfosco commented on a change in pull request #28533:
URL: https://github.com/apache/spark/pull/28533#discussion_r426010810



##########
File path: examples/src/main/scala/org/apache/spark/examples/ml/ChiSqSelectorExample.scala
##########
@@ -30,9 +30,10 @@ object ChiSqSelectorExample {
       .builder
       .appName("ChiSqSelectorExample")
       .getOrCreate()
-    import spark.implicits._
 
     // $example on$
+    import spark.implicits._

Review comment:
       Ok, I'll go ahead and close the PR.  Thanks for the review.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28533: Update ChiSqSelectorExample to show import

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28533:
URL: https://github.com/apache/spark/pull/28533#discussion_r425532560



##########
File path: examples/src/main/scala/org/apache/spark/examples/ml/ChiSqSelectorExample.scala
##########
@@ -30,9 +30,10 @@ object ChiSqSelectorExample {
       .builder
       .appName("ChiSqSelectorExample")
       .getOrCreate()
-    import spark.implicits._
 
     // $example on$
+    import spark.implicits._

Review comment:
       I think this isn't required when you run a Spark shell. Looks intentionally excluded given that `val spark` initialization isn't involved already.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28533: Update ChiSqSelectorExample to show import

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28533:
URL: https://github.com/apache/spark/pull/28533#issuecomment-628931346


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org