You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/09 07:29:40 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3056: Add Decimal128 and Decimal256 to downcast_primitive

viirya commented on code in PR #3056:
URL: https://github.com/apache/arrow-rs/pull/3056#discussion_r1017523307


##########
arrow/src/row/mod.rs:
##########
@@ -726,6 +697,21 @@ unsafe fn decode_column(
             )))
         }
     };
+    let array: ArrayRef = match &field.data_type {

Review Comment:
   As the change doesn't touch timestamp array, I think that you didn't mean the issue is caused by this change, but suggested that we should also fix it together, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org