You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/04 04:09:24 UTC
[GitHub] [spark] 1104056452 opened a new pull request, #36446: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows System
1104056452 opened a new pull request, #36446:
URL: https://github.com/apache/spark/pull/36446
What changes were proposed in this pull request?
The File.getCanonicalPath method will return the drive letter in the windows system. The RpcEnvFileServer.validateDirectoryUri method uses the File.getCanonicalPath method to process the baseuri, which will cause the baseuri not to comply with the URI verification rules. For example, the / classes is processed into F: \ classes.
This PR modified the RpcEnvFileServer.validateDirectoryUri method to increase the conversion to Windows system, so that baseUri conforms to the URI check rule.
Why are the changes needed?
Fix the startup error of spark shell on Windows system
[[SPARK-35691](https://issues.apache.org/jira/browse/SPARK-35691)] introduced this regression.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually tested in local, Rpcenvsuite failed before modification, but it can succeed after modification
It can run on windows, and the basic functions are normal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 1104056452 closed pull request #36446: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows System
Posted by GitBox <gi...@apache.org>.
1104056452 closed pull request #36446: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows System
URL: https://github.com/apache/spark/pull/36446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] 1104056452 closed pull request #36446: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows System
Posted by GitBox <gi...@apache.org>.
1104056452 closed pull request #36446: [SPARK-38807][CORE] Fix the startup error of spark shell on Windows System
URL: https://github.com/apache/spark/pull/36446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org