You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by marti1125 <gi...@git.apache.org> on 2015/05/01 07:53:14 UTC
[GitHub] cordova-medic pull request: added Firefox OS
GitHub user marti1125 opened a pull request:
https://github.com/apache/cordova-medic/pull/49
added Firefox OS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marti1125/cordova-medic CB-8734
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-medic/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit c6365d0756acd0d88bb4f2ae3761ef7eb80771ad
Author: Willy Aguirre <ma...@gmail.com>
Date: 2015-05-01T05:41:53Z
added Firefox OS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: added Firefox OS
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-medic/pull/49#issuecomment-98319951
you will need to add the dependency to package.json also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: added Firefox OS
Posted by marti1125 <gi...@git.apache.org>.
Github user marti1125 closed the pull request at:
https://github.com/apache/cordova-medic/pull/49
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: added Firefox OS
Posted by marti1125 <gi...@git.apache.org>.
Github user marti1125 commented on the pull request:
https://github.com/apache/cordova-medic/pull/49#issuecomment-99508694
any update about it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: added Firefox OS
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/49#discussion_r29528708
--- Diff: medic/medic-run.js ---
@@ -333,6 +333,25 @@ function main() {
var buildCommand = cli + " build " + platform + " -- " + platformArgs;
var runCommand = cli + " run " + platform + " -- " + platformArgs;
+ if(platform === util.FIREFOXOS) {
+
+ var runServe = cli + " serve";
+
+ // run the code
+ // NOTE:
+ // this is ASYNCHRONOUS
+ util.medicLog("running:");
+ util.medicLog(" " + runServe);
+ shelljs.exec(runServe, {silent: false, async: true}, function (returnCode, output) {
+ if (returnCode != 0 || CORDOVA_ERROR_PATTERN.test(output)) {
+ util.fatal("run failed");
+ } else {
+ window.open("http://localhost:8000/firefoxos/www/");
--- End diff --
This script is run from node, which does not have the `window` object. To open the app you will need to launch a real browser via command line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: added Firefox OS
Posted by marti1125 <gi...@git.apache.org>.
Github user marti1125 commented on the pull request:
https://github.com/apache/cordova-medic/pull/49#issuecomment-99524085
this PR is generating conflict with some files....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: added Firefox OS
Posted by marti1125 <gi...@git.apache.org>.
Github user marti1125 commented on the pull request:
https://github.com/apache/cordova-medic/pull/49#issuecomment-98301504
I added this lib https://www.npmjs.com/package/open
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org