You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "lingsamuel (via GitHub)" <gi...@apache.org> on 2023/04/03 09:23:23 UTC

[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #1741: e2e: require certificate from file and add certificate generation script

lingsamuel commented on PR #1741:
URL: https://github.com/apache/apisix-ingress-controller/pull/1741#issuecomment-1493978943

   The issue was intended to solve two problems: the large number of raw certificates in e2e is hard to read and understand, and there is no renewal mechanism.
   What I want is to add the renewal mechanism, which is equivalent to being able to dynamically generate new certificates every time you run e2e, so that the reader can understand the configuration by read the certificates' generation parameters.
   
   Therefore, instead of simply splitting the certificates into files, you should modify the CI workflow to dynamically generate these certificates.
   Also, the `keyCompare` should be modified too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org