You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/01/28 05:40:31 UTC

[kudu-CR] cmake: remove unnecessary link_directories()

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/1941

to review the following change.

Change subject: cmake: remove unnecessary link_directories()
......................................................................

cmake: remove unnecessary link_directories()

While trying to reduce my unit tests' rpath, I stumbled upon this. It's no
longer necessary (perhaps due to the llvm 3.7 upgrade), and removing it
trims the library search path and rpath for all binaries.

In the end shortening the rpaths didn't help (chrpath refuses to grow a
binary's rpath, only rewrite it), but I think the patch still makes sense.

Change-Id: I60af144c324cc41bf01b3d878a549530f578fec8
---
M CMakeLists.txt
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/1941/1
-- 
To view, visit http://gerrit.cloudera.org:8080/1941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I60af144c324cc41bf01b3d878a549530f578fec8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>