[GitHub] [cassandra] dcapwell commented on a change in pull request #1176: CASSANDRA-16900 - ArrayCell#unsharedHeapSizeExcludingData includes data twice

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #1176:
URL: https://github.com/apache/cassandra/pull/1176#discussion_r698685191



##########
File path: src/java/org/apache/cassandra/db/rows/BufferCell.java
##########
@@ -43,7 +45,7 @@ public BufferCell(ColumnMetadata column, long timestamp, int ttl, int localDelet
     {
         super(column);
         assert !column.isPrimaryKeyColumn();
-        assert column.isComplex() == (path != null);
+        assert column.isComplex() == (path != null) : format("Column %s.%s(%s: %s) isComplex: %b with cellpath: %s", column.ksName, column.cfName, column.name, column.type.toString(), column.isComplex(), path);

Review comment:
       this is a nit from me; asserts should have messages to help (not needed for the patch, but is useful)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org