You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "tballison (via GitHub)" <gi...@apache.org> on 2023/11/01 16:36:56 UTC
[PR] NUTCH-3020 -- ParseSegment should check for okhttp's truncation flag [nutch]
tballison opened a new pull request, #794:
URL: https://github.com/apache/nutch/pull/794
Thanks for your contribution to [Apache Nutch](https://nutch.apache.org/)! Your help is appreciated!
Before opening the pull request, please verify that
* there is an open issue on the [Nutch issue tracker](https://issues.apache.org/jira/projects/NUTCH) which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
* the issue ID (`NUTCH-XXXX`)
- is referenced in the title of the pull request
- and placed in front of your commit messages surrounded by square brackets (`[NUTCH-XXXX] Issue or pull request title`)
* commits are squashed into a single one (or few commits for larger changes)
* Java source code follows [Nutch Eclipse Code Formatting rules](https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml)
* Nutch is successfully built and unit tests pass by running `ant clean runtime test`
* there should be no conflicts when merging the pull request branch into the *recent* master branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled master branch.
* if new dependencies are added,
- are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](https://www.apache.org/legal/resolved.html#category-a)?
- are `LICENSE-binary` and `NOTICE-binary` updated accordingly?
We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Nutch in general, please sign up for the [Nutch mailing list](https://nutch.apache.org/mailing_lists.html). Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NUTCH-3020 -- ParseSegment should check for okhttp's truncation flag [nutch]
Posted by "lewismc (via GitHub)" <gi...@apache.org>.
lewismc commented on PR #794:
URL: https://github.com/apache/nutch/pull/794#issuecomment-1789810071
We have no tests for `ParseSegment` right now. I think it would be excellent if this PR could include a test for `ParseSegment.isTruncated`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NUTCH-3020 -- ParseSegment should check for okhttp's truncation flag [nutch]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison merged PR #794:
URL: https://github.com/apache/nutch/pull/794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org